Enable CA1012: Abstract types should not have public constructors (#13940)

xtqqczze · web-flow · commit 60643e27df03 · 2020-11-21T20:07:28.000+05:00
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1012
diff --git a/.globalconfig b/.globalconfig
@@ -24,7 +24,8 @@ dotnet_diagnostic.CA1008.severity = none
 dotnet_diagnostic.CA1010.severity = silent
 
 # CA1012: Abstract types should not have public constructors
-dotnet_diagnostic.CA1012.severity = none
+dotnet_diagnostic.CA1012.severity = warning
+dotnet_code_quality.ca1012.api_surface = all
 
 # CA1014: Mark assemblies with CLSCompliant
 dotnet_diagnostic.CA1014.severity = none
diff --git a/src/Microsoft.Management.Infrastructure.CimCmdlets/CimAsyncOperation.cs b/src/Microsoft.Management.Infrastructure.CimCmdlets/CimAsyncOperation.cs
@@ -28,7 +28,7 @@ internal abstract class CimAsyncOperation : IDisposable
         /// <summary>
         /// The constructor.
         /// </summary>
-        public CimAsyncOperation()
+        protected CimAsyncOperation()
         {
             this.moreActionEvent = new ManualResetEventSlim(false);
             this.actionQueue = new ConcurrentQueue<CimBaseAction>();
diff --git a/src/Microsoft.Management.Infrastructure.CimCmdlets/CimBaseAction.cs b/src/Microsoft.Management.Infrastructure.CimCmdlets/CimBaseAction.cs
@@ -19,7 +19,7 @@ internal abstract class CimBaseAction
         /// <summary>
         /// Constructor method.
         /// </summary>
-        public CimBaseAction()
+        protected CimBaseAction()
         {
         }
 
diff --git a/src/Microsoft.Management.Infrastructure.CimCmdlets/CimResultObserver.cs b/src/Microsoft.Management.Infrastructure.CimCmdlets/CimResultObserver.cs
@@ -69,7 +69,7 @@ internal abstract class AsyncResultEventArgsBase : EventArgs
         /// <param name="session"></param>
         /// <param name="observable"></param>
         /// <param name="resultType"></param>
-        public AsyncResultEventArgsBase(
+        protected AsyncResultEventArgsBase(
             CimSession session,
             IObservable<object> observable,
             AsyncResultType resultType)
@@ -86,7 +86,7 @@ public AsyncResultEventArgsBase(
         /// <param name="observable"></param>
         /// <param name="resultType"></param>
         /// <param name="context"></param>
-        public AsyncResultEventArgsBase(
+        protected AsyncResultEventArgsBase(
             CimSession session,
             IObservable<object> observable,
             AsyncResultType resultType,
diff --git a/src/System.Management.Automation/engine/debugger/debugger.cs b/src/System.Management.Automation/engine/debugger/debugger.cs
@@ -4198,7 +4198,7 @@ public Guid ParentDebuggerId
         /// <param name="runspace">Runspace.</param>
         /// <param name="runspaceType">Runspace type.</param>
         /// <param name="parentDebuggerId">Debugger Id of parent.</param>
-        public NestedRunspaceDebugger(
+        protected NestedRunspaceDebugger(
             Runspace runspace,
             PSMonitorRunspaceType runspaceType,
             Guid parentDebuggerId)
diff --git a/src/System.Management.Automation/engine/interpreter/ControlFlowInstructions.cs b/src/System.Management.Automation/engine/interpreter/ControlFlowInstructions.cs
@@ -204,7 +204,7 @@ internal abstract class IndexedBranchInstruction : Instruction
 
         internal readonly int _labelIndex;
 
-        public IndexedBranchInstruction(int labelIndex)
+        protected IndexedBranchInstruction(int labelIndex)
         {
             _labelIndex = labelIndex;
         }
diff --git a/src/System.Management.Automation/utils/ObjectReader.cs b/src/System.Management.Automation/utils/ObjectReader.cs
@@ -21,7 +21,7 @@ internal abstract class ObjectReaderBase<T> : PipelineReader<T>, IDisposable
         /// </summary>
         /// <param name="stream">The stream to read.</param>
         /// <exception cref="ArgumentNullException">Thrown if the specified stream is null.</exception>
-        public ObjectReaderBase([In, Out] ObjectStreamBase stream)
+        protected ObjectReaderBase([In, Out] ObjectStreamBase stream)
         {
             if (stream == null)
             {

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ internal abstract class CimAsyncOperation : IDisposable`
`28`	`28`	`/// <summary>`
`29`	`29`	`/// The constructor.`
`30`	`30`	`/// </summary>`
`31`		`- public CimAsyncOperation()`
	`31`	`+ protected CimAsyncOperation()`
`32`	`32`	`{`
`33`	`33`	`this.moreActionEvent = new ManualResetEventSlim(false);`
`34`	`34`	`this.actionQueue = new ConcurrentQueue<CimBaseAction>();`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ internal abstract class CimBaseAction`
`19`	`19`	`/// <summary>`
`20`	`20`	`/// Constructor method.`
`21`	`21`	`/// </summary>`
`22`		`- public CimBaseAction()`
	`22`	`+ protected CimBaseAction()`
`23`	`23`	`{`
`24`	`24`	`}`
`25`	`25`
Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ internal abstract class IndexedBranchInstruction : Instruction`
`204`	`204`
`205`	`205`	`internal readonly int _labelIndex;`
`206`	`206`
`207`		`- public IndexedBranchInstruction(int labelIndex)`
	`207`	`+ protected IndexedBranchInstruction(int labelIndex)`
`208`	`208`	`{`
`209`	`209`	`_labelIndex = labelIndex;`
`210`	`210`	`}`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ internal abstract class ObjectReaderBase<T> : PipelineReader<T>, IDisposable`
`21`	`21`	`/// </summary>`
`22`	`22`	`/// <param name="stream">The stream to read.</param>`
`23`	`23`	`/// <exception cref="ArgumentNullException">Thrown if the specified stream is null.</exception>`
`24`		`- public ObjectReaderBase([In, Out] ObjectStreamBase stream)`
	`24`	`+ protected ObjectReaderBase([In, Out] ObjectStreamBase stream)`
`25`	`25`	`{`
`26`	`26`	`if (stream == null)`
`27`	`27`	`{`