Enable SA1000: Keywords should be spaced correctly

xtqqczze · xtqqczze · commit 75eacccd57ff · 2020-11-10T01:03:01.000Z
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1000.md
diff --git a/.globalconfig b/.globalconfig
@@ -1009,7 +1009,7 @@ dotnet_diagnostic.SA0001.severity = none
 dotnet_diagnostic.SA0002.severity = none
 
 # SA1000: Keywords should be spaced correctly
-dotnet_diagnostic.SA1000.severity = none
+dotnet_diagnostic.SA1000.severity = warning
 
 # SA1001: Commas should be spaced correctly
 dotnet_diagnostic.SA1001.severity = none
diff --git a/src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs b/src/Microsoft.PowerShell.Commands.Utility/commands/utility/UnblockFile.cs
@@ -146,10 +146,10 @@ protected override void ProcessRecord()
 
             foreach (string path in pathsToProcess)
             {
-                if(IsBlocked(path))
+                if (IsBlocked(path))
                 {
                     UInt32 result = RemoveXattr(path, MacBlockAttribute, RemovexattrFollowSymLink);
-                    if(result != 0)
+                    if (result != 0)
                     {
                         string errorMessage = string.Format(CultureInfo.CurrentUICulture, UnblockFileStrings.UnblockError, path);
                         Exception e = new InvalidOperationException(errorMessage);
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ProgressPane.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ProgressPane.cs
@@ -102,9 +102,9 @@ class ProgressPane
 
                 // create cleared region to clear progress bar later
                 _savedRegion = tempProgressRegion;
-                for(int row = 0; row < rows; row++)
+                for (int row = 0; row < rows; row++)
                 {
-                    for(int col = 0; col < cols; col++)
+                    for (int col = 0; col < cols; col++)
                     {
                         _savedRegion[row, col].Character = ' ';
                     }
diff --git a/src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs b/src/System.Management.Automation/engine/Modules/ImportModuleCommand.cs
@@ -2024,15 +2024,15 @@ internal override IList<PSModuleInfo> ImportModulesUsingWinCompat(IEnumerable<st
             // perform necessary preparations if module has to be imported with NoClobber mode
             if (filteredModuleNames != null)
             {
-                foreach(string moduleName in filteredModuleNames)
+                foreach (string moduleName in filteredModuleNames)
                 {
                     PrepareNoClobberWinCompatModuleImport(moduleName, null, ref importModuleOptions);
                 }
             }
 
             if (filteredModuleFullyQualifiedNames != null)
             {
-                foreach(var moduleSpec in filteredModuleFullyQualifiedNames)
+                foreach (var moduleSpec in filteredModuleFullyQualifiedNames)
                 {
                     PrepareNoClobberWinCompatModuleImport(null, moduleSpec, ref importModuleOptions);
                 }
diff --git a/src/System.Management.Automation/engine/TypeMetadata.cs b/src/System.Management.Automation/engine/TypeMetadata.cs
@@ -978,7 +978,7 @@ private string GetProxyAttributeData(Attribute attrib, string prefix)
                 string or = string.Empty;
                 string[] regexOptionEnumValues = Enum.GetNames(typeof(System.Text.RegularExpressions.RegexOptions));
 
-                foreach(string regexOption in regexOptionEnumValues)
+                foreach (string regexOption in regexOptionEnumValues)
                 {
                     System.Text.RegularExpressions.RegexOptions option = (System.Text.RegularExpressions.RegexOptions) Enum.Parse(
                         typeof(System.Text.RegularExpressions.RegexOptions),
diff --git a/test/tools/TestExe/TestExe.cs b/test/tools/TestExe/TestExe.cs
@@ -13,7 +13,7 @@ static int Main(string[] args)
         {
             if (args.Length > 0)
             {
-                switch(args[0].ToLowerInvariant())
+                switch (args[0].ToLowerInvariant())
                 {
                     case "-echoargs":
                         EchoArgs(args);
diff --git a/test/tools/WebListener/Controllers/ResumeController.cs b/test/tools/WebListener/Controllers/ResumeController.cs
@@ -30,12 +30,12 @@ public async void Index()
             if (TryGetRangeHeader(out rangeHeader))
             {
                 var range = GetRange(rangeHeader);
-                if(range.From != null)
+                if (range.From != null)
                 {
                     from = (int)range.From;
                 }
 
-                if(range.To != null)
+                if (range.To != null)
                 {
                     to = (int)range.To;
                 }
@@ -49,7 +49,7 @@ public async void Index()
                 return;
             }
 
-            if(to >= FileBytes.Length || from >= FileBytes.Length)
+            if (to >= FileBytes.Length || from >= FileBytes.Length)
             {
                 Response.StatusCode = StatusCodes.Status416RequestedRangeNotSatisfiable;
                 Response.Headers[HeaderNames.ContentRange] = $"bytes */{FileBytes.Length}";
@@ -113,7 +113,7 @@ private void SetResumeResponseHeaders()
         private bool TryGetRangeHeader(out string rangeHeader)
         {
             var rangeHeaderSv = new StringValues();
-            if(Request.Headers.TryGetValue("Range", out rangeHeaderSv))
+            if (Request.Headers.TryGetValue("Range", out rangeHeaderSv))
             {
                 rangeHeader = rangeHeaderSv.FirstOrDefault();
                 return true;

Original file line number	Diff line number	Diff line change
`@@ -146,10 +146,10 @@ protected override void ProcessRecord()`
`146`	`146`
`147`	`147`	`foreach (string path in pathsToProcess)`
`148`	`148`	`{`
`149`		`- if(IsBlocked(path))`
	`149`	`+ if (IsBlocked(path))`
`150`	`150`	`{`
`151`	`151`	`UInt32 result = RemoveXattr(path, MacBlockAttribute, RemovexattrFollowSymLink);`
`152`		`- if(result != 0)`
	`152`	`+ if (result != 0)`
`153`	`153`	`{`
`154`	`154`	`string errorMessage = string.Format(CultureInfo.CurrentUICulture, UnblockFileStrings.UnblockError, path);`
`155`	`155`	`Exception e = new InvalidOperationException(errorMessage);`
Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,9 @@ class ProgressPane`
`102`	`102`
`103`	`103`	`// create cleared region to clear progress bar later`
`104`	`104`	`_savedRegion = tempProgressRegion;`
`105`		`- for(int row = 0; row < rows; row++)`
	`105`	`+ for (int row = 0; row < rows; row++)`
`106`	`106`	`{`
`107`		`- for(int col = 0; col < cols; col++)`
	`107`	`+ for (int col = 0; col < cols; col++)`
`108`	`108`	`{`
`109`	`109`	`_savedRegion[row, col].Character = ' ';`
`110`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2024,15 +2024,15 @@ internal override IList<PSModuleInfo> ImportModulesUsingWinCompat(IEnumerable<st`
`2024`	`2024`	`// perform necessary preparations if module has to be imported with NoClobber mode`
`2025`	`2025`	`if (filteredModuleNames != null)`
`2026`	`2026`	`{`
`2027`		`- foreach(string moduleName in filteredModuleNames)`
	`2027`	`+ foreach (string moduleName in filteredModuleNames)`
`2028`	`2028`	`{`
`2029`	`2029`	`PrepareNoClobberWinCompatModuleImport(moduleName, null, ref importModuleOptions);`
`2030`	`2030`	`}`
`2031`	`2031`	`}`
`2032`	`2032`
`2033`	`2033`	`if (filteredModuleFullyQualifiedNames != null)`
`2034`	`2034`	`{`
`2035`		`- foreach(var moduleSpec in filteredModuleFullyQualifiedNames)`
	`2035`	`+ foreach (var moduleSpec in filteredModuleFullyQualifiedNames)`
`2036`	`2036`	`{`
`2037`	`2037`	`PrepareNoClobberWinCompatModuleImport(null, moduleSpec, ref importModuleOptions);`
`2038`	`2038`	`}`
Original file line number	Diff line number	Diff line change
`@@ -978,7 +978,7 @@ private string GetProxyAttributeData(Attribute attrib, string prefix)`
`978`	`978`	`string or = string.Empty;`
`979`	`979`	`string[] regexOptionEnumValues = Enum.GetNames(typeof(System.Text.RegularExpressions.RegexOptions));`
`980`	`980`
`981`		`- foreach(string regexOption in regexOptionEnumValues)`
	`981`	`+ foreach (string regexOption in regexOptionEnumValues)`
`982`	`982`	`{`
`983`	`983`	`System.Text.RegularExpressions.RegexOptions option = (System.Text.RegularExpressions.RegexOptions) Enum.Parse(`
`984`	`984`	`typeof(System.Text.RegularExpressions.RegexOptions),`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ static int Main(string[] args)`
`13`	`13`	`{`
`14`	`14`	`if (args.Length > 0)`
`15`	`15`	`{`
`16`		`- switch(args[0].ToLowerInvariant())`
	`16`	`+ switch (args[0].ToLowerInvariant())`
`17`	`17`	`{`
`18`	`18`	`case "-echoargs":`
`19`	`19`	`EchoArgs(args);`
Original file line number	Diff line number	Diff line change
`@@ -30,12 +30,12 @@ public async void Index()`
`30`	`30`	`if (TryGetRangeHeader(out rangeHeader))`
`31`	`31`	`{`
`32`	`32`	`var range = GetRange(rangeHeader);`
`33`		`- if(range.From != null)`
	`33`	`+ if (range.From != null)`
`34`	`34`	`{`
`35`	`35`	`from = (int)range.From;`
`36`	`36`	`}`
`37`	`37`
`38`		`- if(range.To != null)`
	`38`	`+ if (range.To != null)`
`39`	`39`	`{`
`40`	`40`	`to = (int)range.To;`
`41`	`41`	`}`
`@@ -49,7 +49,7 @@ public async void Index()`
`49`	`49`	`return;`
`50`	`50`	`}`
`51`	`51`
`52`		`- if(to >= FileBytes.Length \|\| from >= FileBytes.Length)`
	`52`	`+ if (to >= FileBytes.Length \|\| from >= FileBytes.Length)`
`53`	`53`	`{`
`54`	`54`	`Response.StatusCode = StatusCodes.Status416RequestedRangeNotSatisfiable;`
`55`	`55`	`Response.Headers[HeaderNames.ContentRange] = $"bytes */{FileBytes.Length}";`
`@@ -113,7 +113,7 @@ private void SetResumeResponseHeaders()`
`113`	`113`	`private bool TryGetRangeHeader(out string rangeHeader)`
`114`	`114`	`{`
`115`	`115`	`var rangeHeaderSv = new StringValues();`
`116`		`- if(Request.Headers.TryGetValue("Range", out rangeHeaderSv))`
	`116`	`+ if (Request.Headers.TryGetValue("Range", out rangeHeaderSv))`
`117`	`117`	`{`
`118`	`118`	`rangeHeader = rangeHeaderSv.FirstOrDefault();`
`119`	`119`	`return true;`