Avoid array allocations from GetDirectories and GetFiles (#14327)

xtqqczze · web-flow · commit 778cff029227 · 2021-02-16T10:31:02.000-08:00
Contributes to #14318.
diff --git a/src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs b/src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs
@@ -6416,7 +6416,7 @@ private PSModuleInfo AnalyzeScriptFile(string filename, bool force, ExecutionCon
 
                 try
                 {
-                    foreach (string item in System.IO.Directory.GetFiles(baseDirectory, "*.ps1"))
+                    foreach (string item in System.IO.Directory.EnumerateFiles(baseDirectory, "*.ps1"))
                     {
                         module.AddDetectedFunctionExport(Path.GetFileNameWithoutExtension(item));
                     }

Original file line number	Diff line number	Diff line change
`@@ -6416,7 +6416,7 @@ private PSModuleInfo AnalyzeScriptFile(string filename, bool force, ExecutionCon`
`6416`	`6416`
`6417`	`6417`	`try`
`6418`	`6418`	`{`
`6419`		`- foreach (string item in System.IO.Directory.GetFiles(baseDirectory, "*.ps1"))`
	`6419`	`+ foreach (string item in System.IO.Directory.EnumerateFiles(baseDirectory, "*.ps1"))`
`6420`	`6420`	`{`
`6421`	`6421`	`module.AddDetectedFunctionExport(Path.GetFileNameWithoutExtension(item));`
`6422`	`6422`	`}`