Skip to content

Commit 9f1f676

Browse files
xtqqczzextqqczze
authored
Fix IDE0090: Simplify new expression part 2 (#14200)
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0090
1 parent 3c1261f commit 9f1f676

28 files changed

+203
-203
lines changed

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/CimJobException.cs‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ internal static CimJobException CreateFromCimException(
9090
Dbg.Assert(cimException != null, "Caller should verify cimException != null");
9191

9292
string message = BuildErrorMessage(jobDescription, jobContext, cimException.Message);
93-
CimJobException cimJobException = new CimJobException(message, cimException);
93+
CimJobException cimJobException = new(message, cimException);
9494
cimJobException.InitializeErrorRecord(jobContext, cimException);
9595
return cimJobException;
9696
}
@@ -111,7 +111,7 @@ internal static CimJobException CreateFromAnyException(
111111
}
112112

113113
string message = BuildErrorMessage(jobDescription, jobContext, inner.Message);
114-
CimJobException cimJobException = new CimJobException(message, inner);
114+
CimJobException cimJobException = new(message, inner);
115115
var containsErrorRecord = inner as IContainsErrorRecord;
116116
if (containsErrorRecord != null)
117117
{
@@ -142,7 +142,7 @@ internal static CimJobException CreateWithFullControl(
142142
Dbg.Assert(!string.IsNullOrEmpty(message), "Caller should verify message != null");
143143
Dbg.Assert(!string.IsNullOrEmpty(errorId), "Caller should verify errorId != null");
144144

145-
CimJobException cimJobException = new CimJobException(jobContext.PrependComputerNameToMessage(message), inner);
145+
CimJobException cimJobException = new(jobContext.PrependComputerNameToMessage(message), inner);
146146
cimJobException.InitializeErrorRecord(jobContext, errorId, errorCategory);
147147
return cimJobException;
148148
}
@@ -156,7 +156,7 @@ internal static CimJobException CreateWithoutJobContext(
156156
Dbg.Assert(!string.IsNullOrEmpty(message), "Caller should verify message != null");
157157
Dbg.Assert(!string.IsNullOrEmpty(errorId), "Caller should verify errorId != null");
158158

159-
CimJobException cimJobException = new CimJobException(message, inner);
159+
CimJobException cimJobException = new(message, inner);
160160
cimJobException.InitializeErrorRecord(null, errorId, errorCategory);
161161
return cimJobException;
162162
}
@@ -170,7 +170,7 @@ internal static CimJobException CreateFromMethodErrorCode(string jobDescription,
170170

171171
string errorMessage = BuildErrorMessage(jobDescription, jobContext, rawErrorMessage);
172172

173-
CimJobException cje = new CimJobException(errorMessage);
173+
CimJobException cje = new(errorMessage);
174174
cje.InitializeErrorRecord(jobContext, "CimJob_" + methodName + "_" + errorCodeFromMethod, ErrorCategory.InvalidResult);
175175

176176
return cje;
@@ -197,15 +197,15 @@ private static string BuildErrorMessage(string jobDescription, CimJobContext job
197197

198198
private void InitializeErrorRecordCore(CimJobContext jobContext, Exception exception, string errorId, ErrorCategory errorCategory)
199199
{
200-
ErrorRecord coreErrorRecord = new ErrorRecord(
200+
ErrorRecord coreErrorRecord = new(
201201
exception: exception,
202202
errorId: errorId,
203203
errorCategory: errorCategory,
204204
targetObject: jobContext?.TargetObject);
205205

206206
if (jobContext != null)
207207
{
208-
System.Management.Automation.Remoting.OriginInfo originInfo = new System.Management.Automation.Remoting.OriginInfo(
208+
System.Management.Automation.Remoting.OriginInfo originInfo = new(
209209
jobContext.Session.ComputerName,
210210
Guid.Empty);
211211

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/TerminatingErrorTracker.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ internal class TerminatingErrorTracker
2424
#region Getting tracker for a given cmdlet invocation
2525

2626
private static readonly ConditionalWeakTable<InvocationInfo, TerminatingErrorTracker> s_invocationToTracker =
27-
new ConditionalWeakTable<InvocationInfo, TerminatingErrorTracker>();
27+
new();
2828

2929
private static int GetNumberOfSessions(InvocationInfo invocationInfo)
3030
{
@@ -100,7 +100,7 @@ private TerminatingErrorTracker(int numberOfSessions)
100100

101101
#region Tracking session's "connectivity" status
102102

103-
private readonly ConcurrentDictionary<CimSession, bool> _sessionToIsConnected = new ConcurrentDictionary<CimSession, bool>();
103+
private readonly ConcurrentDictionary<CimSession, bool> _sessionToIsConnected = new();
104104

105105
internal void MarkSessionAsConnected(CimSession connectedSession)
106106
{
@@ -166,7 +166,7 @@ internal Exception GetExceptionIfBrokenSession(
166166

167167
#region Tracking session's "terminated" status
168168

169-
private readonly ConcurrentDictionary<CimSession, bool> _sessionToIsTerminated = new ConcurrentDictionary<CimSession, bool>();
169+
private readonly ConcurrentDictionary<CimSession, bool> _sessionToIsTerminated = new();
170170

171171
internal void MarkSessionAsTerminated(CimSession terminatedSession, out bool sessionWasAlreadyTerminated)
172172
{
@@ -196,8 +196,8 @@ internal bool IsSessionTerminated(CimSession session)
196196

197197
internal CmdletMethodInvoker<bool> GetErrorReportingDelegate(ErrorRecord errorRecord)
198198
{
199-
ManualResetEventSlim manualResetEventSlim = new ManualResetEventSlim();
200-
object lockObject = new object();
199+
ManualResetEventSlim manualResetEventSlim = new();
200+
object lockObject = new();
201201
Func<Cmdlet, bool> action = (Cmdlet cmdlet) =>
202202
{
203203
_numberOfReportedSessionTerminatingErrors++;

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimChildJobBase.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ internal CimChildJobBase(CimJobContext jobContext)
5757
_jobSpecificCustomOptions = new Lazy<CimCustomOptionsDictionary>(this.CalculateJobSpecificCustomOptions);
5858
}
5959

60-
private readonly CimSensitiveValueConverter _cimSensitiveValueConverter = new CimSensitiveValueConverter();
60+
private readonly CimSensitiveValueConverter _cimSensitiveValueConverter = new();
6161

6262
internal CimSensitiveValueConverter CimSensitiveValueConverter { get { return _cimSensitiveValueConverter; } }
6363

@@ -158,7 +158,7 @@ public virtual void OnCompleted()
158158
});
159159
}
160160

161-
private static readonly Random s_globalRandom = new Random();
161+
private static readonly Random s_globalRandom = new();
162162
private readonly Random _random;
163163
private int _sleepAndRetryDelayRangeMs = 1000;
164164
private int _sleepAndRetryExtraDelayMs = 0;
@@ -543,7 +543,7 @@ private CimCustomOptionsDictionary GetJobSpecificCustomOptions()
543543

544544
#region Controlling job state
545545

546-
private readonly CancellationTokenSource _cancellationTokenSource = new CancellationTokenSource();
546+
private readonly CancellationTokenSource _cancellationTokenSource = new();
547547

548548
/// <summary>
549549
/// Stops this job.
@@ -578,7 +578,7 @@ public override void StopJob()
578578
_cancellationTokenSource.Cancel();
579579
}
580580

581-
private readonly object _jobStateLock = new object();
581+
private readonly object _jobStateLock = new();
582582
private bool _jobHadErrors;
583583
private bool _jobWasStarted;
584584
private bool _jobWasStopped;
@@ -730,7 +730,7 @@ internal void SetCompletedJobState(JobState state, Exception reason)
730730

731731
#region Support for progress reporting
732732

733-
private readonly ConcurrentDictionary<int, ProgressRecord> _activityIdToLastProgressRecord = new ConcurrentDictionary<int, ProgressRecord>();
733+
private readonly ConcurrentDictionary<int, ProgressRecord> _activityIdToLastProgressRecord = new();
734734

735735
internal override void WriteProgress(ProgressRecord progressRecord)
736736
{

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimCmdletInvocationContext.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ private static void WarnAboutUnsupportedActionPreferences(
7676
if (actionPreferenceComesFromCommandLineParameter)
7777
{
7878
Exception exception = new ArgumentException(message);
79-
ErrorRecord errorRecord = new ErrorRecord(exception, "ActionPreferenceNotSupportedByCimCmdletAdapter", ErrorCategory.NotImplemented, null);
79+
ErrorRecord errorRecord = new(exception, "ActionPreferenceNotSupportedByCimCmdletAdapter", ErrorCategory.NotImplemented, null);
8080
cmdlet.ThrowTerminatingError(errorRecord);
8181
}
8282
}
@@ -113,7 +113,7 @@ public bool ShowComputerName
113113
}
114114
}
115115

116-
private readonly Lazy<CimSession> _defaultCimSession = new Lazy<CimSession>(CreateDefaultCimSession);
116+
private readonly Lazy<CimSession> _defaultCimSession = new(CreateDefaultCimSession);
117117

118118
private static CimSession CreateDefaultCimSession()
119119
{

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimConverter.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ private void Dispose(bool disposing)
129129
}
130130
}
131131

132-
private readonly List<IDisposable> _trackedDisposables = new List<IDisposable>();
132+
private readonly List<IDisposable> _trackedDisposables = new();
133133

134134
/// <summary>
135135
/// Releases resources associated with this object.

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimOperationOptionsHelper.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace Microsoft.PowerShell.Cmdletization.Cim
1717
internal class CimCustomOptionsDictionary
1818
{
1919
private readonly IDictionary<string, object> _dict;
20-
private readonly object _dictModificationLock = new object();
20+
private readonly object _dictModificationLock = new();
2121

2222
private CimCustomOptionsDictionary(IEnumerable<KeyValuePair<string, object>> wrappedDictionary)
2323
{
@@ -42,7 +42,7 @@ internal static CimCustomOptionsDictionary Create(IEnumerable<KeyValuePair<strin
4242
return new CimCustomOptionsDictionary(wrappedDictionary);
4343
}
4444

45-
private static readonly ConditionalWeakTable<CimInstance, CimCustomOptionsDictionary> s_cimInstanceToCustomOptions = new ConditionalWeakTable<CimInstance, CimCustomOptionsDictionary>();
45+
private static readonly ConditionalWeakTable<CimInstance, CimCustomOptionsDictionary> s_cimInstanceToCustomOptions = new();
4646

4747
internal static void AssociateCimInstanceWithCustomOptions(CimInstance cimInstance, CimCustomOptionsDictionary newCustomOptions)
4848
{

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimQuery.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ internal class CimQuery : QueryBuilder, ISessionBoundQueryBuilder<CimSession>
2727
private string _resultRole;
2828
private string _sourceRole;
2929

30-
internal readonly Dictionary<string, object> queryOptions = new Dictionary<string, object>(StringComparer.OrdinalIgnoreCase);
30+
internal readonly Dictionary<string, object> queryOptions = new(StringComparer.OrdinalIgnoreCase);
3131

3232
internal ClientSideQuery ClientSideQuery { get; }
3333

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/cimWrapper.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ private bool IsSupportedSession(CimSession cimSession, TerminatingErrorTracker t
281281
cimSession.ComputerName,
282282
nameOfUnsupportedSwitch);
283283
Exception exception = new NotSupportedException(errorMessage);
284-
ErrorRecord errorRecord = new ErrorRecord(
284+
ErrorRecord errorRecord = new(
285285
exception,
286286
"NoExtendedSemanticsSupportInRemoteDcomProtocol",
287287
ErrorCategory.NotImplemented,
@@ -338,7 +338,7 @@ internal override StartableJob CreateStaticMethodInvocationJob(CimSession sessio
338338

339339
#region Session affinity management
340340

341-
private static readonly ConditionalWeakTable<CimInstance, CimSession> s_cimInstanceToSessionOfOrigin = new ConditionalWeakTable<CimInstance, CimSession>();
341+
private static readonly ConditionalWeakTable<CimInstance, CimSession> s_cimInstanceToSessionOfOrigin = new();
342342

343343
internal static void AssociateSessionOfOriginWithInstance(CimInstance cimInstance, CimSession sessionOfOrigin)
344344
{
@@ -394,10 +394,10 @@ object IDynamicParameters.GetDynamicParameters()
394394

395395
if (this.CmdletDefinitionContext.ExposeCimNamespaceParameter)
396396
{
397-
Collection<Attribute> namespaceAttributes = new Collection<Attribute>();
397+
Collection<Attribute> namespaceAttributes = new();
398398
namespaceAttributes.Add(new ValidateNotNullOrEmptyAttribute());
399399
namespaceAttributes.Add(new ParameterAttribute());
400-
RuntimeDefinedParameter namespaceRuntimeParameter = new RuntimeDefinedParameter(
400+
RuntimeDefinedParameter namespaceRuntimeParameter = new(
401401
CimNamespaceParameter,
402402
typeof(string),
403403
namespaceAttributes);

‎src/Microsoft.PowerShell.Commands.Management/cimSupport/cmdletization/cim/clientSideQuery.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public virtual IEnumerable<NotFoundError> GetNotFoundErrors_IfThisIsTheOnlyFilte
153153

154154
private abstract class CimInstancePropertyBasedFilter : CimInstanceFilterBase
155155
{
156-
private readonly List<PropertyValueFilter> _propertyValueFilters = new List<PropertyValueFilter>();
156+
private readonly List<PropertyValueFilter> _propertyValueFilters = new();
157157

158158
protected IEnumerable<PropertyValueFilter> PropertyValueFilters { get { return _propertyValueFilters; } }
159159

@@ -624,8 +624,8 @@ private static bool ActualValueLessThanOrEqualToExpectedValue(string propertyNam
624624
private int _numberOfResultsFromMi;
625625
private int _numberOfMatchingResults;
626626

627-
private readonly List<CimInstanceFilterBase> _filters = new List<CimInstanceFilterBase>();
628-
private readonly object _myLock = new object();
627+
private readonly List<CimInstanceFilterBase> _filters = new();
628+
private readonly object _myLock = new();
629629

630630
#region "Public" interface for client-side filtering
631631

‎src/Microsoft.PowerShell.Commands.Management/commands/management/AddContentCommand.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ internal override void SeekContentPosition(List<ContentHolder> contentHolders)
4040
catch (Exception e) // Catch-all OK, 3rd party callout
4141
{
4242
ProviderInvocationException providerException =
43-
new ProviderInvocationException(
43+
new(
4444
"ProviderSeekError",
4545
SessionStateStrings.ProviderSeekError,
4646
holder.PathInfo.Provider,

0 commit comments

Comments
 (0)