-
Notifications
You must be signed in to change notification settings - Fork 8.2k
The "Create GitHub draft release" stage depends on changelog update to be merged #19545
Copy link
Copy link
Closed
Labels
In-PRIndicates that a PR is out for the issueIndicates that a PR is out for the issueResolution-FixedThe issue is fixed.The issue is fixed.WG-Maintainers-Buildspecific to affecting the buildspecific to affecting the build
Description
Prerequisites
- Write a descriptive title.
- Make sure you are able to repro it on the latest released version
- Search the existing issues.
- Refer to the FAQ.
- Refer to Differences between Windows PowerShell 5.1 and PowerShell.
Steps to reproduce
The "Create GitHub draft release" stage depends on changelog update to be merged:
PowerShell/tools/releaseBuild/azureDevOps/templates/release-CreateGitHubDraft.yml
Lines 72 to 82 in e0eb5ca
| $filePath = "$env:BUILD_SOURCESDIRECTORY/CHANGELOG/$fileName" | |
| Write-Verbose -Verbose "Selected Log file: $filePath" | |
| if (-not (Test-Path $filePath)) { | |
| throw "$filePath not found" | |
| } | |
| $changelog = Get-Content -Path $filePath | |
| $startPattern = "^## \[" + ([regex]::Escape($releaseVersion)) + "\]" | |
| $endPattern = "^## \[{0}\.{1}\.{2}*" -f $semanticVersion.Major, $semanticVersion.Minor, $semanticVersion.Patch |
However, it doesn't call out this dependency in the release pipeline. Therefore, if you start to run this step without having the changelog update merged to the release branch, the "Create GitHub Draft release" job will fail.
Expected behavior
This dependency should be called out in the release -- maybe as an manual approval step, so that the one who drives the release can avoid running into failure in this step.Actual behavior
This dependency is not called out in the pipeline.Error details
No response
Environment data
N/AVisuals
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
In-PRIndicates that a PR is out for the issueIndicates that a PR is out for the issueResolution-FixedThe issue is fixed.The issue is fixed.WG-Maintainers-Buildspecific to affecting the buildspecific to affecting the build