-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Closed
Labels
Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or more
Description
Here is a CR comment in #4020:
I see that you are following a pattern like
IsSameFileSystemItemorIsHardLink. Ideally, code here should be refactored to consolidate Unix/Windows implementations in one place and eliminate wrapper functions likeIsSameFileSystemItemandIsHardLink. Instead, they should be
internal static bool IsSameFileSystemItem(string pathOne, string pathTwo)
{
#if UNIX
// Unix implementation goes here
#else
// Windows implementation goes here
#endif
}The code should be refactored to reflect the above comment.
- Refactor the existing methods there to consolidate the Unix/Windows implementations at one place.
- The type is
InternalSymbolicLinkLinkCodeMethods, so for utility methods that are not directly related toSymbolicLink, such asGetInodeData, maybe a separate type should be created to hold them.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Issue-Enhancementthe issue is more of a feature request than a bugthe issue is more of a feature request than a bugResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or more