-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Investigate/code clean up ifdef in RemoteSessionNamedPipe.cs #8925
Copy link
Copy link
Closed
Labels
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or more
Description
As called out in #8889...
in regards to:
PowerShell/src/System.Management.Automation/engine/remoting/common/RemoteSessionNamedPipe.cs
Lines 555 to 557 in 1be3f4c
| #if !CORECLR // There is only one AppDomain per application in CoreCLR, which would be the default | |
| CreateAppDomainUnloadHandler(); | |
| #endif |
@PaulHigin said:
This code attempts to dispose the default pipe server on process (appdomain) exit, but it is disabled for CORECLR and so is dead code. This code should be removed or fixed to dispose both the default and custom pipe server objects.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Issue-Code Cleanupthe issue is for cleaning up the code with no impact on functionalitythe issue is for cleaning up the code with no impact on functionalityResolution-No ActivityIssue has had no activity for 6 months or moreIssue has had no activity for 6 months or more