From 2d794e125fe327f7f129a08845eeb7ea5dbce743 Mon Sep 17 00:00:00 2001 From: Thomas Nieto <38873752+ThomasNieto@users.noreply.github.com> Date: Mon, 6 Jan 2020 23:26:58 -0600 Subject: [PATCH 1/3] Remove RequireLicenseAcceptance default value --- .../engine/Modules/NewModuleManifestCommand.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs b/src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs index 47413af9b70..52062986cec 100644 --- a/src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs +++ b/src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs @@ -477,7 +477,7 @@ public object PrivateData /// Gets or sets whether or not the module requires explicit user acceptance for install/update/save. /// [Parameter] - public SwitchParameter RequireLicenseAcceptance { get; set; } = true; + public SwitchParameter RequireLicenseAcceptance { get; set; } /// /// Gets or sets the external module dependencies. From 9a7d2e64e752b5f2281091d93dde8093c211d8ee Mon Sep 17 00:00:00 2001 From: Thomas Nieto <38873752+ThomasNieto@users.noreply.github.com> Date: Mon, 6 Jan 2020 23:27:40 -0600 Subject: [PATCH 2/3] Update RequireLicenseAcceptance test --- test/powershell/engine/Module/NewModuleManifest.Tests.ps1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 b/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 index faacc9f3551..1716e83e8f9 100644 --- a/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 +++ b/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 @@ -58,7 +58,7 @@ Describe "New-ModuleManifest basic tests" -tags "CI" { $module.RequiredModules | Should -BeExactly 'PSReadline' $module.PrivateData.PSData.ExternalModuleDependencies | Should -BeExactly 'PSReadline' $module.PrivateData.PSData.Prerelease | Should -BeExactly 'prerelease' - $module.PrivateData.PSData.RequireLicenseAcceptance | Should -BeExactly $true + $module.PrivateData.PSData.RequireLicenseAcceptance | Should -BeNullOrEmpty } } From 3bc42046cb82af6c98cb0d0332d346805bb0da75 Mon Sep 17 00:00:00 2001 From: Thomas Nieto <38873752+ThomasNieto@users.noreply.github.com> Date: Tue, 7 Jan 2020 08:26:52 -0600 Subject: [PATCH 3/3] Fix RequireLicenseAcceptance tests --- test/powershell/engine/Module/NewModuleManifest.Tests.ps1 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 b/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 index 1716e83e8f9..8b86ecb1479 100644 --- a/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 +++ b/test/powershell/engine/Module/NewModuleManifest.Tests.ps1 @@ -24,6 +24,7 @@ Describe "New-ModuleManifest basic tests" -tags "CI" { $module.Name | Should -BeExactly "test" $module.ModuleType | Should -BeExactly "Manifest" $module.Version | Should -BeExactly "0.0.1" + $module.PrivateData.PSData.RequireLicenseAcceptance | Should -BeNullOrEmpty } It "Verify manifest fields 2" { @@ -58,7 +59,7 @@ Describe "New-ModuleManifest basic tests" -tags "CI" { $module.RequiredModules | Should -BeExactly 'PSReadline' $module.PrivateData.PSData.ExternalModuleDependencies | Should -BeExactly 'PSReadline' $module.PrivateData.PSData.Prerelease | Should -BeExactly 'prerelease' - $module.PrivateData.PSData.RequireLicenseAcceptance | Should -BeNullOrEmpty + $module.PrivateData.PSData.RequireLicenseAcceptance | Should -BeExactly $true } }