v1.0.5 - bug fixes for clearing handlers

Someguy123 · Someguy123 · commit 25498863f23d · 2019-07-05T03:55:30.000+01:00
diff --git a/privex/loghelper/LogHelper.py b/privex/loghelper/LogHelper.py
@@ -97,7 +97,13 @@ def __init__(self, logger_name = None, level = logging.DEBUG, handler_level = lo
 
         self.log = logging.getLogger(logger_name)
         if clear_handlers:
-            self.log.handlers.clear()
+            l = self.log
+            # Clear any existing handlers, to avoid duplicate logs
+            for h in l.handlers:
+                l.removeHandler(h)
+            # Ensure propagation is enabled, and the logger itself is enabled
+            l.propagate = True
+            l.disabled = False
         self.log.setLevel(self.level)
 
     def get_logger(self):
@@ -139,7 +145,11 @@ def copy_logger(self, *logger_names):
             l = logging.getLogger(ln)
             l.setLevel(self.level)
             # Clear any existing handlers, to avoid duplicate logs
-            l.handlers = []
+            for h in l.handlers:
+                l.removeHandler(h)
+            # Ensure propagation is enabled, and the logger itself is enabled
+            l.propagate = True
+            l.disabled = False
             # Now re-generate the handlers using the add_xxx methods, as simply running add_handler with the
             # previously generated handler instances results in duplicate logging.
             for hname, hkwargs in self.handlers:
diff --git a/setup.py b/setup.py
@@ -28,7 +28,7 @@
 setup(
     name='privex_loghelper',
 
-    version='1.0.4',
+    version='1.0.5',
 
     description='Small dependency-free class to make logging easier',
     long_description=long_description,
