Skip to content

Commit 75a3df8

Browse files
committed
Collapse Objective-C code
Due to cocoadocs thinking we're a Objective-C pod, removing some lines
1 parent 53515a8 commit 75a3df8

File tree

2 files changed

+21
-95
lines changed

2 files changed

+21
-95
lines changed

QueryKit/ObjectiveC/QKAttribute.m

Lines changed: 18 additions & 91 deletions
Original file line numberDiff line numberDiff line change
@@ -103,18 +103,9 @@ - (NSUInteger)length {
103103

104104
#pragma mark - Comparison
105105

106-
- (NSPredicate *)predicateWithRightExpression:(NSExpression *)expression
107-
modifier:(NSComparisonPredicateModifier)modifier
108-
type:(NSPredicateOperatorType)type
109-
options:(NSComparisonPredicateOptions)options
110-
{
106+
- (NSPredicate *)predicateWithRightExpression:(NSExpression *)expression modifier:(NSComparisonPredicateModifier)modifier type:(NSPredicateOperatorType)type options:(NSComparisonPredicateOptions)options {
111107
NSExpression *leftExpression = [self expression];
112-
113-
return [NSComparisonPredicate predicateWithLeftExpression:leftExpression
114-
rightExpression:expression
115-
modifier:modifier
116-
type:type
117-
options:options];
108+
return [NSComparisonPredicate predicateWithLeftExpression:leftExpression rightExpression:expression modifier:modifier type:type options:options];
118109
}
119110

120111
@end
@@ -123,11 +114,7 @@ @implementation QKAttribute (Predicate)
123114

124115
- (NSPredicate *)equal:(id)value options:(NSComparisonPredicateOptions)options {
125116
NSExpression *expression = [NSExpression expressionForConstantValue:value];
126-
127-
return [self predicateWithRightExpression:expression
128-
modifier:NSDirectPredicateModifier
129-
type:NSEqualToPredicateOperatorType
130-
options:options];
117+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSEqualToPredicateOperatorType options:options];
131118
}
132119

133120
- (NSPredicate *)equal:(id)value {
@@ -136,11 +123,7 @@ - (NSPredicate *)equal:(id)value {
136123

137124
- (NSPredicate *)notEqual:(id)value options:(NSComparisonPredicateOptions)options {
138125
NSExpression *expression = [NSExpression expressionForConstantValue:value];
139-
140-
return [self predicateWithRightExpression:expression
141-
modifier:NSDirectPredicateModifier
142-
type:NSNotEqualToPredicateOperatorType
143-
options:options];
126+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSNotEqualToPredicateOperatorType options:options];
144127
}
145128

146129
- (NSPredicate *)notEqual:(id)value {
@@ -149,11 +132,7 @@ - (NSPredicate *)notEqual:(id)value {
149132

150133
- (NSPredicate *)beginsWith:(id)value options:(NSComparisonPredicateOptions)options {
151134
NSExpression *expression = [NSExpression expressionForConstantValue:value];
152-
153-
return [self predicateWithRightExpression:expression
154-
modifier:NSDirectPredicateModifier
155-
type:NSBeginsWithPredicateOperatorType
156-
options:options];
135+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSBeginsWithPredicateOperatorType options:options];
157136
}
158137

159138
- (NSPredicate *)beginsWith:(id)value {
@@ -162,11 +141,7 @@ - (NSPredicate *)beginsWith:(id)value {
162141

163142
- (NSPredicate *)endsWith:(id)value options:(NSComparisonPredicateOptions)options {
164143
NSExpression *expression = [NSExpression expressionForConstantValue:value];
165-
166-
return [self predicateWithRightExpression:expression
167-
modifier:NSDirectPredicateModifier
168-
type:NSEndsWithPredicateOperatorType
169-
options:options];
144+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSEndsWithPredicateOperatorType options:options];
170145
}
171146

172147
- (NSPredicate *)endsWith:(id)value {
@@ -175,11 +150,7 @@ - (NSPredicate *)endsWith:(id)value {
175150

176151
- (NSPredicate *)like:(id)value options:(NSComparisonPredicateOptions)options {
177152
NSExpression *expression = [NSExpression expressionForConstantValue:value];
178-
179-
return [self predicateWithRightExpression:expression
180-
modifier:NSDirectPredicateModifier
181-
type:NSLikePredicateOperatorType
182-
options:options];
153+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSLikePredicateOperatorType options:options];
183154
}
184155

185156
- (NSPredicate *)like:(id)value {
@@ -188,11 +159,7 @@ - (NSPredicate *)like:(id)value {
188159

189160
- (NSPredicate *)matches:(id)value options:(NSComparisonPredicateOptions)options {
190161
NSExpression *expression = [NSExpression expressionForConstantValue:value];
191-
192-
return [self predicateWithRightExpression:expression
193-
modifier:NSDirectPredicateModifier
194-
type:NSMatchesPredicateOperatorType
195-
options:options];
162+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSMatchesPredicateOperatorType options:options];
196163
}
197164

198165
- (NSPredicate *)matches:(id)value {
@@ -201,81 +168,49 @@ - (NSPredicate *)matches:(id)value {
201168

202169
- (NSPredicate *)greaterThan:(id)value {
203170
NSExpression *expression = [NSExpression expressionForConstantValue:value];
204-
205-
return [self predicateWithRightExpression:expression
206-
modifier:NSDirectPredicateModifier
207-
type:NSGreaterThanPredicateOperatorType
208-
options:0];
171+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSGreaterThanPredicateOperatorType options:0];
209172
}
210173

211174
- (NSPredicate *)greaterThanOrEqualTo:(id)value {
212175
NSExpression *expression = [NSExpression expressionForConstantValue:value];
213-
214-
return [self predicateWithRightExpression:expression
215-
modifier:NSDirectPredicateModifier
216-
type:NSGreaterThanOrEqualToPredicateOperatorType
217-
options:0];
176+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSGreaterThanOrEqualToPredicateOperatorType options:0];
218177
}
219178

220179
- (NSPredicate *)lessThan:(id)value {
221180
NSExpression *expression = [NSExpression expressionForConstantValue:value];
222-
223-
return [self predicateWithRightExpression:expression
224-
modifier:NSDirectPredicateModifier
225-
type:NSLessThanPredicateOperatorType
226-
options:0];
181+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSLessThanPredicateOperatorType options:0];
227182
}
228183

229184
- (NSPredicate *)lessThanOrEqualTo:(id)value {
230185
NSExpression *expression = [NSExpression expressionForConstantValue:value];
231-
232-
return [self predicateWithRightExpression:expression
233-
modifier:NSDirectPredicateModifier
234-
type:NSLessThanOrEqualToPredicateOperatorType
235-
options:0];
186+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSLessThanOrEqualToPredicateOperatorType options:0];
236187
}
237188

238189
- (NSPredicate *)isNil {
239190
NSExpression *expression = [NSExpression expressionForConstantValue:nil];
240-
241-
return [self predicateWithRightExpression:expression
242-
modifier:NSDirectPredicateModifier
243-
type:NSEqualToPredicateOperatorType
244-
options:0];
191+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSEqualToPredicateOperatorType options:0];
245192
}
246193

247194
- (NSPredicate *)between:(id)minimumValue and:(id)maxiumValue {
248195
NSParameterAssert(minimumValue != nil);
249196
NSParameterAssert(maxiumValue != nil);
250197

251198
NSExpression *expression = [NSExpression expressionForConstantValue:@[minimumValue, maxiumValue]];
252-
253-
return [self predicateWithRightExpression:expression
254-
modifier:NSDirectPredicateModifier
255-
type:NSBetweenPredicateOperatorType
256-
options:0];
199+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSBetweenPredicateOperatorType options:0];
257200
}
258201

259202
- (NSPredicate *)in:(id<NSFastEnumeration>)set {
260203
NSParameterAssert(set != nil);
261204

262205
NSExpression *expression = [NSExpression expressionForConstantValue:set];
263-
264-
return [self predicateWithRightExpression:expression
265-
modifier:NSDirectPredicateModifier
266-
type:NSInPredicateOperatorType
267-
options:0];
206+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSInPredicateOperatorType options:0];
268207
}
269208

270209
- (NSPredicate *)contains:(id)value options:(NSComparisonPredicateOptions)options {
271210
NSParameterAssert(value != nil);
272211

273212
NSExpression *expression = [NSExpression expressionForConstantValue:value];
274-
275-
return [self predicateWithRightExpression:expression
276-
modifier:NSDirectPredicateModifier
277-
type:NSContainsPredicateOperatorType
278-
options:options];
213+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSContainsPredicateOperatorType options:options];
279214
}
280215

281216
- (NSPredicate *)contains:(id)value {
@@ -284,20 +219,12 @@ - (NSPredicate *)contains:(id)value {
284219

285220
- (NSPredicate *)isYes {
286221
NSExpression *expression = [NSExpression expressionForConstantValue:@YES];
287-
288-
return [self predicateWithRightExpression:expression
289-
modifier:NSDirectPredicateModifier
290-
type:NSEqualToPredicateOperatorType
291-
options:0];
222+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSEqualToPredicateOperatorType options:0];
292223
}
293224

294225
- (NSPredicate *)isNo {
295226
NSExpression *expression = [NSExpression expressionForConstantValue:@NO];
296-
297-
return [self predicateWithRightExpression:expression
298-
modifier:NSDirectPredicateModifier
299-
type:NSEqualToPredicateOperatorType
300-
options:0];
227+
return [self predicateWithRightExpression:expression modifier:NSDirectPredicateModifier type:NSEqualToPredicateOperatorType options:0];
301228
}
302229

303230
@end

QueryKit/ObjectiveC/QKQuerySet.m

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ - (BOOL)isEqualToQuerySet:(QKQuerySet *)queryset {
7979
[self.predicate isEqual:[queryset predicate]] &&
8080
[self.sortDescriptors isEqual:[queryset sortDescriptors]] &&
8181
NSEqualRanges(self.range, queryset.range)
82-
);
82+
);
8383
}
8484

8585
#pragma mark - NSCopying
@@ -260,9 +260,8 @@ - (NSManagedObject *)object:(NSError **)error {
260260
if (count == 1) {
261261
managedObject = [array firstObject];
262262
} else if ((count > 1) && error != nil) {
263-
*error = [NSError errorWithDomain:QKQuerySetErrorDomain code:0 userInfo:@{
264-
NSLocalizedDescriptionKey: @"Find object in fetch request failed, should only result in a single result.",
265-
}];
263+
NSString *errorDescription = @"Find object in fetch request failed, should only result in a single result.";
264+
*error = [NSError errorWithDomain:QKQuerySetErrorDomain code:0 userInfo:@{ NSLocalizedDescriptionKey: errorDescription }];
266265
}
267266

268267
return managedObject;

0 commit comments

Comments
 (0)