Improve error logging

Thibaut · Thibaut · commit 6fc48db8af14 · 2017-07-16T15:41:25.000-04:00
diff --git a/lib/docs/core/response.rb b/lib/docs/core/response.rb
@@ -8,8 +8,8 @@ def error?
       code == 0 || code != 404 && code != 403 && code >= 400 && code <= 599
     end
 
-    def empty?
-      body.empty?
+    def blank?
+      body.blank?
     end
 
     def mime_type
diff --git a/lib/docs/core/scrapers/url_scraper.rb b/lib/docs/core/scrapers/url_scraper.rb
@@ -35,7 +35,9 @@ def request_options
 
     def process_response?(response)
       if response.error?
-        raise "Error status code (#{response.code}): #{response.url}"
+        raise "Error status code (#{response.code}): #{response.return_message}\n#{response.url}"
+      elsif response.blank?
+        raise "Empty response body: #{response.url}"
       end
 
       response.success? && response.html? && process_url?(response.effective_url)
diff --git a/test/lib/docs/core/response_test.rb b/test/lib/docs/core/response_test.rb
@@ -51,15 +51,15 @@ class DocsResponseTest < MiniTest::Spec
     end
   end
 
-  describe "#empty?" do
-    it "returns true when the body is empty" do
-      options.body = ''
-      assert response.empty?
+  describe "#blank?" do
+    it "returns true when the body is blank" do
+      options.body = ' '
+      assert response.blank?
     end
 
-    it "returns false when the body isn't empty" do
+    it "returns false when the body isn't blank" do
       options.body = 'body'
-      refute response.empty?
+      refute response.blank?
     end
   end
 
