Fix handling of invalid iframe URLs

Thibaut · Thibaut · commit ed5a5cadd9ba · 2017-04-22T10:17:51.000-04:00
Fixes freeCodeCamp#590.
diff --git a/lib/docs/filters/core/normalize_urls.rb b/lib/docs/filters/core/normalize_urls.rb
@@ -15,7 +15,7 @@ def update_attribute(tag, attribute)
       css(tag.to_s).each do |node|
         next unless value = node[attribute]
         next if fragment_url_string?(value) || data_url_string?(value)
-        node[attribute] = normalize_url(value)
+        node[attribute] = normalize_url(value) || (tag == :iframe ? value : '#')
       end
     end
 
@@ -31,7 +31,7 @@ def normalize_url(str)
 
       url.to_s
     rescue URI::InvalidURIError
-      '#'
+      nil
     end
 
     def to_absolute_url(str)
diff --git a/test/lib/docs/filters/core/normalize_urls_test.rb b/test/lib/docs/filters/core/normalize_urls_test.rb
@@ -39,11 +39,21 @@ class NormalizeUrlsFilterTest < MiniTest::Spec
     assert_equal link_to(context[:url]), filter_output_string
   end
 
-  it "rewrites invalid relative urls" do
+  it "rewrites invalid link urls" do
     @body = link_to '%'
     assert_equal link_to('#'), filter_output_string
   end
 
+  it "rewrites invalid image urls" do
+    @body = '<img src="%">'
+    assert_equal '<img src="#">', filter_output_string
+  end
+
+  it "doesn't rewrite invalid iframe urls" do
+    @body = '<iframe src="%"></iframe>'
+    assert_equal @body, filter_output_string
+  end
+
   it "repairs un-encoded spaces" do
     @body = link_to 'http://example.com/#foo bar '
     assert_equal link_to('http://example.com/#foo%20bar'), filter_output_string
