apply review

youknowone · youknowone · commit f401e374c829 · 2026-04-13T16:46:19.000+09:00
diff --git a/crates/stdlib/src/_opcode.rs b/crates/stdlib/src/_opcode.rs
@@ -207,9 +207,12 @@ mod _opcode {
         }
 
         let effect = match jump {
+            Some(true) => opcode.stack_effect_jump(oparg),
             Some(false) => opcode.stack_effect(oparg),
-            // jump=True or jump=None: branch-path effect
-            _ => opcode.stack_effect_jump(oparg),
+            // jump=None: max of both paths (CPython convention)
+            None => opcode
+                .stack_effect(oparg)
+                .max(opcode.stack_effect_jump(oparg)),
         };
         Ok(effect)
     }

Original file line number	Diff line number	Diff line change
`@@ -207,9 +207,12 @@ mod _opcode {`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`let effect = match jump {`
	`210`	`+ Some(true) => opcode.stack_effect_jump(oparg),`
`210`	`211`	`Some(false) => opcode.stack_effect(oparg),`
`211`		`- // jump=True or jump=None: branch-path effect`
`212`		`- _ => opcode.stack_effect_jump(oparg),`
	`212`	`+ // jump=None: max of both paths (CPython convention)`
	`213`	`+ None => opcode`
	`214`	`+ .stack_effect(oparg)`
	`215`	`+ .max(opcode.stack_effect_jump(oparg)),`
`213`	`216`	`};`
`214`	`217`	`Ok(effect)`
`215`	`218`	`}`