Don't thrash byte arrays around so much

pete-woods · pete-woods · commit 0bb3a9c171e5 · 2019-03-14T11:32:55.000Z
diff --git a/src/main/java/microsoft/exchange/webservices/data/core/EwsXmlReader.java b/src/main/java/microsoft/exchange/webservices/data/core/EwsXmlReader.java
@@ -561,16 +561,7 @@ public byte[] readBase64ElementValue()
       throws ServiceXmlDeserializationException, XMLStreamException,
       IOException {
     this.ensureCurrentNodeIsStartElement();
-
-    byte[] buffer = null;
-
-    ByteArrayOutputStream byteArrayStream = new ByteArrayOutputStream();
-
-    buffer = Base64.decodeBase64(this.xmlReader.getElementText().toString());
-    byteArrayStream.write(buffer);
-
-    return byteArrayStream.toByteArray();
-
+    return Base64.decodeBase64(this.xmlReader.getElementText());
   }
 
   /**
@@ -583,8 +574,7 @@ public void readBase64ElementValue(OutputStream outputStream)
       throws Exception {
     this.ensureCurrentNodeIsStartElement();
 
-    byte[] buffer = null;
-    buffer = Base64.decodeBase64(this.xmlReader.getElementText().toString());
+    byte[] buffer = Base64.decodeBase64(this.xmlReader.getElementText());
     outputStream.write(buffer);
     outputStream.flush();
   }
