997 Resolve size_t underflow while removing dublicates in dynamic NPIs by using int (#998)

HenrZu · web-flow · commit 49977549ac8e · 2024-04-18T16:06:27.000+02:00
If damping_expr.get_dampings().size() == 0, 
then damping_expr.get_dampings().size() - 1 
became a very large positive number, not -1
diff --git a/cpp/memilio/epidemiology/dynamic_npis.h b/cpp/memilio/epidemiology/dynamic_npis.h
@@ -320,7 +320,7 @@ void implement_dynamic_npis(DampingExprGroup& damping_expr_group, const std::vec
     for (auto& damping_expr : damping_expr_group) {
         //go from the back so indices aren't invalidated when dampings are removed
         //use indices to loop instead of reverse iterators because removing invalidates the current iterator
-        for (auto i = size_t(0); i < damping_expr.get_dampings().size() - 1; ++i) {
+        for (auto i = int(0); i < int(damping_expr.get_dampings().size()) - 1; ++i) {
             auto it = damping_expr.get_dampings().rbegin() + i;
 
             //look for previous damping of the same type/level
