You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- generate the C++ documentation using doxysphinx
- replaced the inline namespace documentations on model pages by links
- enabled Build on Pull Request
Co-authored-by: Carlotta Gerstein <[email protected]>
Co-authored-by: Henrik Zunker <[email protected]>
-[ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
22
-
-[ ] New code adheres to [coding guidelines](https://memilio.readthedocs.io/en/latest/development.html#coding-guidelines)
23
-
-[ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
24
-
-[ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP)
25
-
-[ ] Appropriate **documentation within the code** (Doxygen) for new functionality has been added in the code
26
-
-[ ] Appropriate **external documentation** (ReadTheDocs) for new functionality has been added to the online documentation
27
-
-[ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added
21
+
-[ ] Every addressed issue is linked (use the "Closes #ISSUE" keyword below).
22
+
-[ ] New code adheres to [coding guidelines](https://memilio.readthedocs.io/en/latest/development.html#coding-guidelines).
23
+
-[ ] No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
24
+
-[ ] Tests are added for new functionality and a local test run was successful (with and without OpenMP).
25
+
-[ ] Appropriate **documentation within the code** (Doxygen) for new functionality has been added in the code.
26
+
-[ ] Appropriate **external documentation** (ReadTheDocs) for new functionality has been added to the online documentation and checked in the preview.
27
+
-[ ] Proper attention to licenses, especially no new third-party software with conflicting license has been added.
28
28
-[ ] (For ABM development) Checked [benchmark results](https://memilio.readthedocs.io/en/latest/development.html#agent-based-model-development) and ran and posted a local test above from before and after development to ensure performance is monitored.
29
29
30
30
### Checks by code reviewer(s)
31
31
32
-
-[ ] Corresponding issue(s) is/are linked and addressed
33
-
-[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
34
-
-[ ] Appropriate **unit tests** have been added, CI passes, code coverage and performance is acceptable (did not decrease)
35
-
-[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
32
+
-[ ] Corresponding issue(s) is/are linked and addressed.
33
+
-[ ] Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.).
34
+
-[ ] Appropriate **unit tests** have been added, CI passes, code coverage and performance is acceptable (did not decrease).
35
+
-[ ] No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.).
36
36
-[ ] On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the **briefly-list-the-changes** above (best case) or the separate commit messages (worst case).
0 commit comments