Loadable Component

Scot3004 · Scot3004 · commit 160bf38a36a1 · 2018-09-17T17:09:04.000-05:00
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-# selenium_python
+# Selenium with Python
 
 ## Install
 
@@ -8,6 +8,12 @@ Please use virtualenv if you don't want to add dependencies to your global pytho
 pip install -r requirements.txt
 ```
 
+## Lint Code
+
+```bash
+pylint ./**/*.py
+```
+
 ## Generate graph
 
 ```bash
diff --git a/classes.png b/classes.png
diff --git a/elements/__init__.py b/elements/__init__.py
@@ -0,0 +1,3 @@
+"""
+Elements abstraction layer
+"""
diff --git a/packages.png b/packages.png
diff --git a/pages/__init__.py b/pages/__init__.py
@@ -0,0 +1,3 @@
+"""
+Pages In Page Object Model defines the components of the real application example main page, login, footer, header...
+"""
diff --git a/pages/main_page.py b/pages/main_page.py
@@ -13,6 +13,9 @@ class MainPage(BasePage):
 
     search_text_element = SearchTextElement()
 
+    def load(self):
+        self.driver.get("http://www.python.org")
+
     def is_title_matches(self):
         """Verifies that the hardcoded text "Python" appears in page title"""
         return "Python" in self.driver.title
diff --git a/requirements.txt b/requirements.txt
@@ -1,4 +1,9 @@
-coverage==4.5.1
-pycallgraph==1.0.1
+astroid==2.0.4
+isort==4.3.4
+lazy-object-proxy==1.3.1
+mccabe==0.6.1
+pylint==2.1.1
 selenium==3.14.0
+six==1.11.0
 urllib3==1.23
+wrapt==1.10.11
diff --git a/tests/base_test.py b/tests/base_test.py
@@ -12,7 +12,6 @@ class BaseTest(unittest.TestCase):
 
     def setUp(self):
         self.driver = webdriver.Firefox()
-        self.driver.get("http://www.python.org")
 
     def tearDown(self):
         self.driver.close()
diff --git a/tests/test_python_search.py b/tests/test_python_search.py
@@ -22,6 +22,7 @@ def test_search_in_python_org(self):
 
         # Load the main page. In this case the home page of Python.org.
         main_page = MainPage(self.driver)
+        main_page.load()
         # Checks if the word "Python" is in title
         assert main_page.is_title_matches(), "python.org title doesn't match."
         # Sets the text of search textbox to "pycon"
diff --git a/tests/test_python_search_without_pom.py b/tests/test_python_search_without_pom.py
@@ -8,10 +8,9 @@
 from tests.base_test import BaseTest
 
 
-class TestPythonOrgSearch(BaseTest):
+class TestPythonOrgSearchNoPOM(BaseTest):
     """A sample test class to show how page object works"""
 
-
     def test_search_in_python_org(self):
         """
         Tests python.org search feature.
@@ -20,6 +19,7 @@ def test_search_in_python_org(self):
         This test verifies that the results were not empty.
         """
 
+        self.driver.get("http://www.python.org")
         # Checks if the word "Python" is in title
         assert "Python" in self.driver.title, "python.org title doesn't match."
         # Sets the text of search textbox to "pycon"

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+"""`
	`2`	`+Elements abstraction layer`
	`3`	`+"""`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+"""`
	`2`	`+Pages In Page Object Model defines the components of the real application example main page, login, footer, header...`
	`3`	`+"""`