App notifications position fixed

manojVivek · manojVivek · commit 7aec92d50631 · 2020-10-14T12:12:47.000+05:30
diff --git a/desktop-app/app/components/AppNotification/AppNotification.js b/desktop-app/app/components/AppNotification/AppNotification.js
@@ -41,7 +41,7 @@ const AppNotification = () => {
   const commonClasses = useCommonStyles();
 
   useEffect(() => {
-    if (process.env.NODE_ENV === 'development') {
+    if (process.env.NODE_ENV === 'development1') {
       return;
     }
     (async () => {
diff --git a/desktop-app/app/components/AppNotification/styles.module.css b/desktop-app/app/components/AppNotification/styles.module.css
@@ -10,6 +10,7 @@
   padding: 10px 20px 20px 20px;
   min-width: 250px;
   max-width: 320px;
+  color: #f8f8f8;
 }
 
 .titleContainer {
diff --git a/desktop-app/app/components/Header/index.js b/desktop-app/app/components/Header/index.js
@@ -10,7 +10,6 @@ import PermissionPopup from '../PermissionPopup';
 
 import NavigationControlsContainer from '../../containers/NavigationControlsContainer';
 import BookmarksBar from '../../containers/BookmarksBarContainer';
-import AppNotification from '../AppNotification/AppNotification';
 import Logo from '../icons/Logo';
 import ZenButton from '../ZenButton';
 import cx from 'classnames';
@@ -54,7 +53,6 @@ const Header = props => {
         pauseOnHover
         toastClassName={classes.darkToast}
       />
-      <AppNotification />
       <ZenButton
         active={!props.isHeaderVisible}
         onClick={() => props.setHeaderVisibility(!props.isHeaderVisible)}
diff --git a/desktop-app/app/containers/Browser/index.js b/desktop-app/app/containers/Browser/index.js
@@ -11,6 +11,7 @@ import LeftIconsPaneContainer from '../LeftIconsPaneContainer';
 import HeaderContainer from '../HeaderContainer';
 import os from 'os';
 import HorizontalSpacer from '../../components/HorizontalSpacer';
+import AppNotification from '../../components/AppNotification/AppNotification';
 
 const Browser = ({browser}) => (
   <Fragment>
@@ -61,6 +62,7 @@ const Browser = ({browser}) => (
         ) : null}
       </div>
     </div>
+    <AppNotification />
   </Fragment>
 );
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ const AppNotification = () => {`
`41`	`41`	`const commonClasses = useCommonStyles();`
`42`	`42`
`43`	`43`	`useEffect(() => {`
`44`		`- if (process.env.NODE_ENV === 'development') {`
	`44`	`+ if (process.env.NODE_ENV === 'development1') {`
`45`	`45`	`return;`
`46`	`46`	`}`
`47`	`47`	`(async () => {`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`padding: 10px 20px 20px 20px;`
`11`	`11`	`min-width: 250px;`
`12`	`12`	`max-width: 320px;`
	`13`	`+ color: #f8f8f8;`
`13`	`14`	`}`
`14`	`15`
`15`	`16`	`.titleContainer {`