Skip to content

Commit ee95687

Browse files
committed
Coverage
1 parent 560f3b6 commit ee95687

7 files changed

Lines changed: 710 additions & 17 deletions

File tree

.eslintrc.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
{
22
"extends": "standard",
3-
//"extends": "strongloop",
4-
//"extends": "eslint:recommended",
53
"env": {
64
"node": true,
75
"es6": true,

.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
.idea
22
.DS_STORE
3-
node_modules
3+
node_modules
4+
coverage

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
language: node_js
22
node_js:
3-
- "node"
3+
- "node"
4+
after_script: "cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ You can activate the http redirect again specifying not only the PORT environmen
5050

5151
#### Close the server
5252
You can close the server with `app.close()`.
53-
Closing the server is an async operation, you can get notified with `app.close(callback)` or `app.close().then(...)`.
53+
Closing the server is an async operation, you can get notified with a promise: `app.close().then(...)`.
5454

5555
---
5656

index.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,10 @@ if (require.main === module) {
5555
}
5656

5757
// ready
58-
if (!process.env.TEST) console.info("Server running on port " + port + ".")
58+
console.info("Server running on port " + port + ".")
5959

6060
// close the app
61-
app.close = (callback) => {
61+
app.close = () => {
6262
const promises = [
6363
new Promise(resolve => app.http.close(resolve)),
6464
new Promise(resolve => app.server.close(resolve))
@@ -67,8 +67,7 @@ app.close = (callback) => {
6767
for (const socketId in sockets)
6868
sockets[socketId].destroy()
6969
return Promise.all(promises).then(() => {
70-
if (!process.env.TEST) console.info("Server closed.")
71-
if (callback) callback()
70+
console.info("Server closed.")
7271
})
7372
}
7473

0 commit comments

Comments
 (0)