New: Add {Season Year} renaming token#8052
New: Add {Season Year} renaming token#8052Yashizzle wants to merge 3 commits intoSonarr:v5-developfrom
{Season Year} renaming token#8052Conversation
This chooses the year the first episode in the season aired and sets that as the `Season Year`. Closes: Sonarr#7667
|
Hi All... It's my first time contributing to your wonderful project. I picked an issue that seemed simple. I've done a bit more testing and it seems like everything works as intended. Please let me know your thoughts and I'll mark it as ready for review if I'm on the right path. Thanks in advance ! |
markus101
left a comment
There was a problem hiding this comment.
Looks pretty solid, just some small improvements. Make sure you mark it ready for review or it will be filtered out from reviewing.
|
Updated to address the comments. Thank you @markus101 !! Updated Screenshot |
|
|
||
| var seasonPath = BuildSeasonPath(series, episodes.First().SeasonNumber); | ||
| var firstEpisode = episodes.First(); | ||
| var seasonPath = BuildSeasonPath(series, firstEpisode.SeasonNumber, firstEpisode.AirDateUtc?.Year); |
There was a problem hiding this comment.
I missed this the first time, but this could result in seasons that span multiple years having folders for different years depending which episodes are imported.
Season years is being added (starting with Skyhook), but it's not available yet, for now I'm going to convert this PR to a draft pending that addition.
Description
{Season Year}token.UnknownScreenshots for UI Changes
Issues Fixed or Closed by this PR
{Season Year}Renaming Token #7667