In the following places:
there is a
return statement in a
finally block, which would swallow any in-flight exception.
This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, it will not propagate on as expected.
If the intention is to suppress all exceptions, I would propose to make this clear by using "except BaseException".
See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.
In the following places:
mail-parser/src/mailparser/mailparser.py
Line 650 in 77fe015
mail-parser/src/mailparser/mailparser.py
Line 663 in 77fe015
there is a
returnstatement in afinallyblock, which would swallow any in-flight exception.This means that if an unhandled exception (including a
BaseExceptionsuch asKeyboardInterrupt) is raised from thetrybody, it will not propagate on as expected.If the intention is to suppress all exceptions, I would propose to make this clear by using "except BaseException".
See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.