-
-
Notifications
You must be signed in to change notification settings - Fork 98
Description
Hi, I found a behavior in the page settings UI on main and wanted to confirm the intended design before submitting a fix.
The question
When selecting a page in the page editor / page settings UI, should that page automatically be loaded on the deck (become active_page)?
I’m asking because the current code seems split between two possible designs:
-
If the intent is “editing a page in the UI should also make it active on the deck”:
- then it looks like a
load_page(...)call is missing when selecting a page for
editing.
- then it looks like a
-
If the intent is “the editor can edit pages without loading them on the deck”:
- then several settings callbacks appear to be wrong because they use
deck_controller.active_pageinstead of the page currently being edited.
- then several settings callbacks appear to be wrong because they use
Current behavior
If I edit page settings (background / brightness / screensaver) for a page that is
not currently active on the deck, the changes aren't applied.
Where this seems to happen
I found this pattern in:
src/windows/mainWindow/elements/PageSettings/BackgroundGroup.pysrc/windows/mainWindow/elements/PageSettings/DeckGroup.py
These callbacks use deck_controller.active_page directly.
Why I’m asking first
I can prepare a fix, but the correct fix depends on the intended behavior:
- load the selected page into the deck when opening/editing it, or
- keep editing “offline” and target the edited page object instead (only live-apply
if it’s active)
Metadata
Metadata
Assignees
Labels
Type
Projects
Status