Skip to content

Clarification needed on Page Settings behavior #559

@morris178

Description

@morris178

Hi, I found a behavior in the page settings UI on main and wanted to confirm the intended design before submitting a fix.

The question

When selecting a page in the page editor / page settings UI, should that page automatically be loaded on the deck (become active_page)?

I’m asking because the current code seems split between two possible designs:

  • If the intent is “editing a page in the UI should also make it active on the deck”:

    • then it looks like a load_page(...) call is missing when selecting a page for
      editing.
  • If the intent is “the editor can edit pages without loading them on the deck”:

    • then several settings callbacks appear to be wrong because they use
      deck_controller.active_page instead of the page currently being edited.

Current behavior

If I edit page settings (background / brightness / screensaver) for a page that is
not currently active on the deck, the changes aren't applied.

Where this seems to happen

I found this pattern in:

  • src/windows/mainWindow/elements/PageSettings/BackgroundGroup.py
  • src/windows/mainWindow/elements/PageSettings/DeckGroup.py

These callbacks use deck_controller.active_page directly.

Why I’m asking first

I can prepare a fix, but the correct fix depends on the intended behavior:

  1. load the selected page into the deck when opening/editing it, or
  2. keep editing “offline” and target the edited page object instead (only live-apply
    if it’s active)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions