Allow exists method to handle out of bounds and wrong type errors#509
Merged
zhigang1992 merged 1 commit intoSwiftyJSON:masterfrom Sep 26, 2016
Merged
Conversation
Contributor
|
Sweet, can you help solve the conflict here and let's ship this. Sorry for not getting to this earlier. |
72f326b to
356ebd2
Compare
- Check for out of bounds error on exists method - Check for wrong type error on exists method - Add tests for cases where out of bounds and wrong type errors occur
356ebd2 to
78fb831
Compare
Contributor
Author
|
@zhigang1992 Okay, rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
existsmethod to handle out of bounds and wrong type errors by checking forerrorValue.code == ErrorIndexOutOfBoundsanderrorValue.code == ErrorWrongType.For example, when we have
let jsonForArray = JSON([["number":1111]])we would expectjsonForArray[1].exists()andjsonForArray["someValue"].exists()to return false.I think the change here might fix the issue related to #498