Skip to content

feat(service): accept commit SHA in read endpoints#3608

Merged
Panaetius merged 8 commits intodevelopfrom
add-commit-sha-in-core-requests-3579
Oct 18, 2023
Merged

feat(service): accept commit SHA in read endpoints#3608
Panaetius merged 8 commits intodevelopfrom
add-commit-sha-in-core-requests-3579

Conversation

@olevski
Copy link
Copy Markdown
Member

@olevski olevski commented Aug 25, 2023 •
edited
Loading

closes #3579

/deploy #persist

This is ready for review.

@olevski olevski requested a review from a team as a code owner August 25, 2023 14:07
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 25, 2023 14:07 — with GitHub Actions Inactive
@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Aug 25, 2023

You can access the deployment of this PR at https://renku-ci-rp-3608.dev.renku.ch

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Aug 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6549700209

  • 37 of 45 (82.22%) changed or added relevant lines in 10 files are covered.
  • 1007 unchanged lines in 82 files lost coverage.
  • Overall coverage decreased (-3.3%) to 82.91%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/util/git.py 7 9 77.78%
renku/ui/service/gateways/repository_cache.py 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/core/dataset/providers/renku.py 1 89.76%
renku/core/image.py 1 97.14%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/workflow/activity.py 1 93.29%
renku/domain_model/dataset.py 1 93.3%
renku/domain_model/provenance/agent.py 1 81.72%
renku/domain_model/template.py 1 90.43%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
Totals Coverage Status
Change from base Build 6544141496: -3.3%
Covered Lines: 25469
Relevant Lines: 30719
💛 - Coveralls

@olevski olevski force-pushed the add-commit-sha-in-core-requests-3579 branch from 189b1ec to 9f12f91 Compare August 25, 2023 14:47
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 25, 2023 14:47 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 28, 2023 14:21 — with GitHub Actions Inactive
@olevski olevski force-pushed the add-commit-sha-in-core-requests-3579 branch from 73e4c25 to 893c4c7 Compare August 28, 2023 14:32
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 28, 2023 14:32 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 28, 2023 16:48 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 29, 2023 13:03 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to renku-ci-rp-3608 August 29, 2023 13:12 — with GitHub Actions Inactive
Panaetius
Panaetius suggested changes Oct 2, 2023
View reviewed changes
Comment thread renku/core/util/git.py Outdated
Comment thread renku/ui/service/gateways/repository_cache.py Outdated
Comment thread renku/ui/service/gateways/repository_cache.py Outdated
Comment thread renku/ui/service/gateways/repository_cache.py Outdated
@olevski olevski temporarily deployed to renku-ci-rp-3608 October 17, 2023 15:14 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to renku-ci-rp-3608 October 17, 2023 15:25 — with GitHub Actions Inactive
@olevski olevski deployed to renku-ci-rp-3608 October 17, 2023 15:51 — with GitHub Actions Active
@Panaetius Panaetius merged commit 01a0798 into develop Oct 18, 2023
@Panaetius Panaetius deleted the add-commit-sha-in-core-requests-3579 branch October 18, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Panaetius Panaetius Panaetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

renku-python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

allow passing non-branch ref to read-only core-svc endpoints

4 participants

@olevski @RenkuBot @coveralls @Panaetius