Skip to content

feat(cli, service): support for project image#3623

Merged
mohammad-alisafaee merged 4 commits intodevelopfrom
3576-project-icon
Oct 4, 2023
Merged

feat(cli, service): support for project image#3623
mohammad-alisafaee merged 4 commits intodevelopfrom
3576-project-icon

Conversation

@mohammad-alisafaee
Copy link
Copy Markdown
Contributor

@mohammad-alisafaee mohammad-alisafaee commented Sep 27, 2023 •
edited
Loading

Description

Adds -i and --image flags to init and project edit commands that accepts a path/URL to an image. The image is copied to .renku/images/project/0.png and added to the project.

NOTE

  • The image is always saved with a PNG extension; this shouldn't matter since UI loads the image correctly regardless (tested with dataset images).
  • We don't allow adding non-image files from the local filesystem

Fixes #3576

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Sep 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6407729967

  • 199 of 209 (95.22%) changed or added relevant lines in 28 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on 3576-project-icon at 85.798%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/dataset/dataset.py 20 21 95.24%
renku/core/migration/m_0010__metadata_fixes.py 1 2 50.0%
renku/core/migration/utils/conversion.py 1 2 50.0%
renku/domain_model/image.py 22 23 95.65%
renku/core/project.py 29 31 93.55%
renku/ui/cli/project.py 13 17 76.47%
Totals Coverage Status
Change from base Build 6407170776: 85.8%
Covered Lines: 26007
Relevant Lines: 30312
💛 - Coveralls

@mohammad-alisafaee mohammad-alisafaee force-pushed the 3576-project-icon branch 2 times, most recently from a6e5a0b to 8c3c6ab Compare October 1, 2023 15:59
@mohammad-alisafaee mohammad-alisafaee force-pushed the 3576-project-icon branch 6 times, most recently from 5b56deb to aacc3e5 Compare October 2, 2023 13:26
@mohammad-alisafaee mohammad-alisafaee changed the title feat(cli, service): support for setting an image for projects feat(cli, service): support for setting image for projects Oct 2, 2023
@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review October 2, 2023 15:10
@mohammad-alisafaee mohammad-alisafaee requested a review from a team as a code owner October 2, 2023 15:10
Panaetius
Panaetius previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, tiny suggestion, feel free to ignore

Comment thread renku/core/project.py Outdated
@mohammad-alisafaee mohammad-alisafaee enabled auto-merge (squash) October 4, 2023 14:52
@mohammad-alisafaee mohammad-alisafaee changed the title feat(cli, service): support for setting image for projects feat(cli, service): support for project image Oct 4, 2023
@mohammad-alisafaee mohammad-alisafaee merged commit db9f93b into develop Oct 4, 2023
@mohammad-alisafaee mohammad-alisafaee deleted the 3576-project-icon branch October 4, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Panaetius Panaetius Panaetius approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

renku-python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for project images in the cli and core-svc

3 participants

@mohammad-alisafaee @coveralls @Panaetius