Skip to content

feat: add prometheus metrics#3640

Merged
Panaetius merged 7 commits intodevelopfrom
add-prometheus-metrics
Oct 18, 2023
Merged

feat: add prometheus metrics#3640
Panaetius merged 7 commits intodevelopfrom
add-prometheus-metrics

Conversation

@Panaetius
Copy link
Copy Markdown
Member

@Panaetius Panaetius commented Oct 13, 2023 •
edited
Loading

Fixes #3434

/deploy extra-values=core.metrics.enabled=true

@Panaetius Panaetius requested a review from a team as a code owner October 13, 2023 08:04
@Panaetius Panaetius temporarily deployed to renku-ci-rp-3640 October 13, 2023 08:22 — with GitHub Actions Inactive
@RenkuBot
Copy link
Copy Markdown
Contributor

RenkuBot commented Oct 13, 2023

You can access the deployment of this PR at https://renku-ci-rp-3640.dev.renku.ch

@Panaetius Panaetius force-pushed the add-prometheus-metrics branch from 6d87be1 to 689929c Compare October 13, 2023 08:29
@Panaetius Panaetius deployed to renku-ci-rp-3640 October 13, 2023 08:29 — with GitHub Actions Active
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 13, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6558358583

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.01%) to 82.909%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/entrypoint.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
renku/core/workflow/activity.py 1 93.61%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
Totals Coverage Status
Change from base Build 6557526422: 0.01%
Covered Lines: 25472
Relevant Lines: 30723
💛 - Coveralls

@Panaetius Panaetius mentioned this pull request Oct 13, 2023
Merged
mohammad-alisafaee
mohammad-alisafaee reviewed Oct 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@mohammad-alisafaee mohammad-alisafaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Does this collect a set of default metrics which are good enough for us?

@Panaetius
Copy link
Copy Markdown
Member Author

Panaetius commented Oct 16, 2023

Thank you! Does this collect a set of default metrics which are good enough for us?

Yes, I think it's pretty comprehensive, for each endpoint. You can see the default metrics here: https://github.com/rycus86/prometheus_flask_exporter#default-metrics

@Panaetius Panaetius force-pushed the add-prometheus-metrics branch from 6006501 to 20bff5d Compare October 16, 2023 08:17
@Panaetius Panaetius force-pushed the add-prometheus-metrics branch from 20bff5d to d8d8305 Compare October 16, 2023 08:26
@Panaetius Panaetius force-pushed the add-prometheus-metrics branch from d8d8305 to 97e1892 Compare October 16, 2023 08:47
@Panaetius Panaetius enabled auto-merge (squash) October 18, 2023 08:37
@Panaetius Panaetius merged commit d3eedb5 into develop Oct 18, 2023
@Panaetius Panaetius deleted the add-prometheus-metrics branch October 18, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohammad-alisafaee mohammad-alisafaee mohammad-alisafaee approved these changes

Assignees

No one assigned

Labels

documentation:pending

Projects

renku-python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add prometheus metrics to core service and rq

4 participants

@Panaetius @RenkuBot @coveralls @mohammad-alisafaee