Skip to content

fix(cli): do not pass the force-build flag to docker#3641

Merged
Panaetius merged 3 commits intodevelopfrom
fix/3612-docker-force-build-flag
Nov 9, 2023
Merged

fix(cli): do not pass the force-build flag to docker#3641
Panaetius merged 3 commits intodevelopfrom
fix/3612-docker-force-build-flag

Conversation

@Panaetius
Copy link
Copy Markdown
Member

Fixes #3612

@Panaetius Panaetius requested a review from a team as a code owner October 16, 2023 12:44
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 16, 2023

Pull Request Test Coverage Report for Build 6810240853

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 82.838%

Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/core/session/docker.py 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
renku/core/workflow/activity.py 1 93.61%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
Totals Coverage Status
Change from base Build 6800487347: -0.01%
Covered Lines: 25452
Relevant Lines: 30725

💛 - Coveralls

@Panaetius Panaetius merged commit ff5e8f6 into develop Nov 9, 2023
@Panaetius Panaetius deleted the fix/3612-docker-force-build-flag branch November 9, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

the --force-build flag should not be in the docker section

3 participants