Skip to content

feat(svc): rename git_url to template_git_url and return git_url on all endpoints#3646

Merged
Panaetius merged 4 commits intodevelopfrom
feat/3564-svc-git-url
Nov 15, 2023
Merged

feat(svc): rename git_url to template_git_url and return git_url on all endpoints#3646
Panaetius merged 4 commits intodevelopfrom
feat/3564-svc-git-url

Conversation

@Panaetius
Copy link
Copy Markdown
Member

@Panaetius Panaetius commented Oct 20, 2023 •
edited
Loading

closes #3564

@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch from 2195f95 to 05446b4 Compare October 20, 2023 11:49
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6850695882

  • 109 of 137 (79.56%) changed or added relevant lines in 12 files are covered.
  • 8 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+3.2%) to 86.024%
Changes Missing Coverage Covered Lines Changed/Added Lines %
renku/ui/service/serializers/templates.py 30 32 93.75%
renku/ui/service/views/v1/templates.py 19 23 82.61%
renku/ui/service/serializers/v1/templates.py 29 51 56.86%
Files with Coverage Reduction New Missed Lines %
renku/core/dataset/dataset.py 1 85.19%
renku/core/dataset/providers/dataverse.py 1 88.86%
renku/core/migration/m_0003__1_jsonld.py 1 87.68%
renku/core/migration/models/v3.py 1 97.24%
renku/ui/cli/init.py 1 96.9%
renku/ui/cli/service.py 1 28.57%
renku/command/rollback.py 2 78.7%
Totals Coverage Status
Change from base Build 6823291196: 3.2%
Covered Lines: 26522
Relevant Lines: 30831
💛 - Coveralls

@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch 3 times, most recently from 9b83a53 to 1253e66 Compare October 20, 2023 15:09
@Panaetius Panaetius marked this pull request as ready for review October 20, 2023 15:40
@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch from 1253e66 to d5ed339 Compare October 20, 2023 15:40
@Panaetius Panaetius requested a review from a team as a code owner October 20, 2023 15:40
@Panaetius
Copy link
Copy Markdown
Member Author

Panaetius commented Oct 20, 2023

This should be ready. Feel free to merge. Need to coordinate with UI when it is merged

olevski
olevski requested changes Nov 9, 2023
View reviewed changes
Comment thread renku/ui/service/serializers/datasets.py
Comment thread renku/ui/service/serializers/templates.py Outdated
Comment thread renku/ui/service/serializers/templates.py
@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch 4 times, most recently from 80f315f to 4891f27 Compare November 10, 2023 15:38
@Panaetius Panaetius force-pushed the feat/3564-svc-git-url branch from 4891f27 to 89cbce9 Compare November 13, 2023 13:31
@Panaetius Panaetius requested a review from olevski November 13, 2023 13:32
@Panaetius Panaetius merged commit 314786e into develop Nov 15, 2023
@Panaetius Panaetius deleted the feat/3564-svc-git-url branch November 15, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olevski olevski olevski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

renku-python
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Return git_url in core-service responses

3 participants

@Panaetius @coveralls @olevski