Add efficient method for none?, add spec

adamcreekroad · adamcreekroad · commit 4ff430af6de0 · 2019-11-18T14:49:54.000-05:00
diff --git a/ruby/hyper-model/lib/reactive_record/active_record/reactive_record/collection.rb b/ruby/hyper-model/lib/reactive_record/active_record/reactive_record/collection.rb
@@ -619,12 +619,21 @@ def empty?
     end
 
     def any?(*args, &block)
-      # If are doing anything other than just checking if there is an object in the collection,
-      # proceed to the normal behavior
-      return super if args&.length&.positive? || block.present?
+      # If there are any args passed in, then the collection is being used in the condition
+      #   and we must load it all into memory.
+      return all.any?(*args, &block) if args&.length&.positive? || block.present?
 
-      # Otherwise just check the count for efficiency
-      count.positive?
+      # Otherwise we can just check the count for efficiency
+      !empty?
+    end
+
+    def none?(*args, &block)
+      # If there are any args passed in, then the collection is being used in the condition
+      #   and we must load it all into memory.
+      return all.none?(*args, &block) if args&.length&.positive? || block.present?
+
+      # Otherwise we can just check the count for efficiency
+      empty?
     end
 
     def method_missing(method, *args, &block)
diff --git a/ruby/hyper-model/spec/batch2/collection_aggregate_methods_spec.rb b/ruby/hyper-model/spec/batch2/collection_aggregate_methods_spec.rb
@@ -32,58 +32,61 @@
     size_window(:small, :portrait)
   end
 
-  [:count, :empty?, :any?].each do |method|
+  %i[count empty? any? none?].each do |method|
     it "will not retrieve the entire collection when using #{method}" do
       FactoryBot.create(:test_model)
 
-      expect_promise(<<-RUBY
-        Hyperstack::Model
-        .load { TestModel.#{method} }
-        .then do |val|
-          if TestModel.all.instance_variable_get('@collection')
-            "unnecessary fetch of all"
-          else
-            val
+      expect_promise(
+        <<~RUBY
+          Hyperstack::Model
+          .load { TestModel.#{method} }
+          .then do |val|
+            if TestModel.all.instance_variable_get('@collection')
+              "unnecessary fetch of all"
+            else
+              val
+            end
           end
-        end
-      RUBY
-    ).to eq(TestModel.all.send(method))
+        RUBY
+      ).to eq(TestModel.all.send(method))
     end
   end
 
-  it 'will retrieve the entire collection when using any? if an arg is passed in' do
-    FactoryBot.create(:test_model)
+  %i[any? none?].each do |method|
+    it 'will retrieve the entire collection when using any? if an arg is passed in' do
+      FactoryBot.create(:test_model)
 
-    expect_promise(
-      <<~RUBY
-        Hyperstack::Model.load do
-          TestModel.any?(TestModel)
-        end.then do |val|
-          if TestModel.all.instance_variable_get('@collection')
-            'necessary fetch of all'
-          else
-            val
+      expect_promise(
+        <<~RUBY
+          Hyperstack::Model.load do
+            TestModel.#{method}(TestModel)
+          end.then do |val|
+            if TestModel.all.instance_variable_get('@collection')
+              'necessary fetch of all'
+            else
+              val
+            end
           end
-        end
-      RUBY
-    ).to eq('necessary fetch of all')
-  end
+        RUBY
+      ).to eq('necessary fetch of all')
+    end
 
-  it 'will retrieve the entire collection when using any? if a block is passed in' do
-    FactoryBot.create(:test_model)
+    it 'will retrieve the entire collection when using any? if a block is passed in' do
+      FactoryBot.create(:test_model)
 
-    expect_promise(
-      <<~RUBY
-        Hyperstack::Model.load do
-          TestModel.any? { |test_model| test_model }
-        end.then do |val|
-          if TestModel.all.instance_variable_get('@collection')
-            'necessary fetch of all'
-          else
-            val
+      expect_promise(
+        <<~RUBY
+          Hyperstack::Model.load do
+            TestModel.#{method} { |test_model| test_model }
+          end.then do |val|
+            if TestModel.all.instance_variable_get('@collection')
+              'necessary fetch of all'
+            else
+              val
+            end
           end
-        end
-      RUBY
-    ).to eq('necessary fetch of all')
+        RUBY
+      ).to eq('necessary fetch of all')
+    end
   end
 end
