added type and model_name default behavior

catmando · catmando · commit ae192a30adba · 2019-11-14T14:46:53.000-05:00
diff --git a/ruby/hyper-model/lib/reactive_record/active_record/class_methods.rb b/ruby/hyper-model/lib/reactive_record/active_record/class_methods.rb
@@ -347,20 +347,11 @@ def server_method(name, default: nil)
       end
     end
 
-    # def define_attribute_methods
-    #   columns_hash.each do |name, column_hash|
-    #     next if name == primary_key
-    #     column_hash[:serialized?] = true if ReactiveRecord::Base.serialized?[self][name]
-    #
-    #     define_method(name) { @backing_record.get_attr_value(name, nil) } unless method_defined?(name)
-    #     define_method("#{name}!") { @backing_record.get_attr_value(name, true) } unless method_defined?("#{name}!")
-    #     define_method("#{name}=") { |val| @backing_record.set_attr_value(name, val) } unless method_defined?("#{name}=")
-    #     define_method("#{name}_changed?") { @backing_record.changed?(name) } unless method_defined?("#{name}_changed?")
-    #     define_method("#{name}?") { @backing_record.get_attr_value(name, nil).present? } unless method_defined?("#{name}?")
-    #   end
-    #   self.inheritance_column = nil if inheritance_column && !columns_hash.key?(inheritance_column)
-    # end
-
+    # define all the methods for each column.  To allow overriding the methods they will NOT
+    # be defined if already defined (i.e. by the model)  See the instance_methods module for how
+    # super calls are handled in this case.   The _hyperstack_internal_setter_... methods
+    # are used by the load_from_json method when bringing in data from the server, and so therefore
+    # does not want to be overriden.
 
     def define_attribute_methods
       columns_hash.each do |name, column_hash|
diff --git a/ruby/hyper-model/lib/reactive_record/active_record/instance_methods.rb b/ruby/hyper-model/lib/reactive_record/active_record/instance_methods.rb
@@ -1,6 +1,19 @@
 module ActiveRecord
   module InstanceMethods
 
+    # if methods are missing, then they must be a column, which we look up
+    # in the columns_hash.
+
+    # For effeciency all attributes will by default have all the methods defined,
+    # when the class is loaded.  See define_attribute_methods class method.
+    # However a model may override the attribute methods definition, but then call
+    # super.  Which will result in the method missing call.
+
+    # When loading data from the server we do NOT want to call overridden methods
+    # so we also define a _hyperstack_internal_setter_... method for each attribute
+    # as well as for belongs_to relationships, server_methods, and the special
+    # type and model_name methods.  See the ClassMethods module for details.
+
     def method_missing(missing, *args, &block)
       column = self.class.columns_hash.detect { |name, *| missing =~ /^#{name}/ }
       if column
@@ -20,6 +33,16 @@ def method_missing(missing, *args, &block)
     # ignore load_from_json when it calls _hyperstack_internal_setter_id
     def _hyperstack_internal_setter_id(*); end
 
+    # the system assumes that there is "virtual" model_name and type attribute so
+    # we define the internal setter here.  If the user defines some other attributes
+    # or uses these names no harm is done since the exact same method would have been
+    # defined by the define_attribute_methods class method anyway.
+    %i[model_name type].each do |attr|
+      define_method("_hyperstack_internal_setter_#{attr}") do |val|
+        @backing_record.set_attr_value(:model_name, val)
+      end
+    end
+
     def inspect
       "<#{model_name}:#{ReactiveRecord::Operations::Base::FORMAT % to_key} "\
       "(#{ReactiveRecord::Operations::Base::FORMAT % object_id}) "\
