Merge pull request #452 from TeamCodeStream/develop

willmiraglia · web-flow · commit b4b2c4067f2f · 2024-06-06T14:29:07.000Z
15.6 backend patch
diff --git a/api_server/CHANGELOG.md b/api_server/CHANGELOG.md
@@ -1,11 +1,15 @@
 # Change Log
 
-## [15.6.0] - 2024-6-3
+## [15.6.0] - 2024-6-6
 
 ### Changed
 
 - Backend changes to support refactor of errors integration
 
+### Fixed
+
+- Fixes an issue with opening in IDE from New Relic using Firefox
+
 ## [15.5.0] - 2024-4-29
 
 ### Changed
diff --git a/api_server/modules/apiweb/templates/partial_launcher_detailed.hbs b/api_server/modules/apiweb/templates/partial_launcher_detailed.hbs
@@ -262,6 +262,10 @@
 							successCb && successCb();
 						}
 
+						function unsupportedCallback() {
+							unsupportedCb && unsupportedCb();
+						}
+
 						if (navigator.msLaunchUri) { //for IE and Edge in Win 8 and Win 10
 							openUriWithMsLaunchUri(uri, failCb, successCb);
 						} else {
@@ -276,8 +280,9 @@
 							} else if (browser.isSafari) {
 								openUriWithHiddenFrame(uri, failCallback, successCallback);
 							} else {
-								unsupportedCb();
-								//not supported, implement please
+								unsupportedCallback();
+								// this works for most common browsers, so we try it if detection fails
+								openUriWithTimeoutHack(uri, failCallback, successCallback);
 							}
 						}
 					}

Original file line number	Diff line number	Diff line change
`@@ -262,6 +262,10 @@`
`262`	`262`	`successCb && successCb();`
`263`	`263`	`}`
`264`	`264`
	`265`	`+ function unsupportedCallback() {`
	`266`	`+ unsupportedCb && unsupportedCb();`
	`267`	`+ }`
	`268`	`+`
`265`	`269`	`if (navigator.msLaunchUri) { //for IE and Edge in Win 8 and Win 10`
`266`	`270`	`openUriWithMsLaunchUri(uri, failCb, successCb);`
`267`	`271`	`} else {`
`@@ -276,8 +280,9 @@`
`276`	`280`	`} else if (browser.isSafari) {`
`277`	`281`	`openUriWithHiddenFrame(uri, failCallback, successCallback);`
`278`	`282`	`} else {`
`279`		`- unsupportedCb();`
`280`		`- //not supported, implement please`
	`283`	`+ unsupportedCallback();`
	`284`	`+ // this works for most common browsers, so we try it if detection fails`
	`285`	`+ openUriWithTimeoutHack(uri, failCallback, successCallback);`
`281`	`286`	`}`
`282`	`287`	`}`
`283`	`288`	`}`