test TwitterTweetFieldsV2

mironal · mironal · commit b69c6f3a1b66 · 2022-03-09T16:53:17.000+09:00
diff --git a/Sources/TwitterAPIKit/APIv2/FieldsV2.swift b/Sources/TwitterAPIKit/APIv2/FieldsV2.swift
@@ -25,6 +25,7 @@ public enum TwitterTweetFieldsV2: TwitterAPIv2RequestParameter, Hashable {
     case source
     case text
     case withheld
+    case other(String)
 
     public var stringValue: String {
 
@@ -69,6 +70,8 @@ public enum TwitterTweetFieldsV2: TwitterAPIv2RequestParameter, Hashable {
             return "text"
         case .withheld:
             return "withheld"
+        case .other(let other):
+            return other
         }
     }
 }
diff --git a/Sources/TwitterAPIKit/APIv2/TwitterAPIv2.swift b/Sources/TwitterAPIKit/APIv2/TwitterAPIv2.swift
@@ -54,7 +54,7 @@ public protocol TwitterAPIv2RequestParameter {
     var stringValue: String { get }
 }
 
-extension Set where Element: TwitterAPIv2RequestParameter {
+extension Collection where Element: TwitterAPIv2RequestParameter {
     var commaSeparatedString: String {
         return map { $0.stringValue }.sorted().joined(separator: ",")
     }
diff --git a/Tests/TwitterAPIKitTests/APIv2/FieldsV2Tests.swift b/Tests/TwitterAPIKitTests/APIv2/FieldsV2Tests.swift
@@ -0,0 +1,47 @@
+import XCTest
+
+@testable import TwitterAPIKit
+
+class FieldsV2Tests: XCTestCase {
+
+    // https://developer.twitter.com/en/docs/twitter-api/data-dictionary/object-model/tweet
+    // [...$0.rows].slice(1).map(tr => { return tr.cells[0].textContent.replace("(default)", "").trim()}).sort().join(",")
+
+    override func setUpWithError() throws {
+    }
+
+    override func tearDownWithError() throws {
+    }
+
+    func testTwitterTweetFieldsV2() throws {
+
+        let allCases: [TwitterTweetFieldsV2] = [
+            .attachments,
+            .authorID,
+            .contextAnnotations,
+            .conversationID,
+            .createdAt,
+            .entities,
+            .geo,
+            .id,
+            .inReplyToUserID,
+            .lang,
+            .nonPublicMetrics,
+            .publicMetrics,
+            .organicMetrics,
+            .promotedMetrics,
+            .possiblySensitive,
+            .referencedTweets,
+            .replySettings,
+            .source,
+            .text,
+            .withheld,
+            .other("~~~"),
+        ]
+
+        XCTAssertEqual(
+            allCases.commaSeparatedString,
+            "attachments,author_id,context_annotations,conversation_id,created_at,entities,geo,id,in_reply_to_user_id,lang,non_public_metrics,organic_metrics,possibly_sensitive,promoted_metrics,public_metrics,referenced_tweets,reply_settings,source,text,withheld,~~~"
+        )
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,7 @@ public enum TwitterTweetFieldsV2: TwitterAPIv2RequestParameter, Hashable {`
`25`	`25`	`case source`
`26`	`26`	`case text`
`27`	`27`	`case withheld`
	`28`	`+ case other(String)`
`28`	`29`
`29`	`30`	`public var stringValue: String {`
`30`	`31`
`@@ -69,6 +70,8 @@ public enum TwitterTweetFieldsV2: TwitterAPIv2RequestParameter, Hashable {`
`69`	`70`	`return "text"`
`70`	`71`	`case .withheld:`
`71`	`72`	`return "withheld"`
	`73`	`+ case .other(let other):`
	`74`	`+ return other`
`72`	`75`	`}`
`73`	`76`	`}`
`74`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public protocol TwitterAPIv2RequestParameter {`
`54`	`54`	`var stringValue: String { get }`
`55`	`55`	`}`
`56`	`56`
`57`		`-extension Set where Element: TwitterAPIv2RequestParameter {`
	`57`	`+extension Collection where Element: TwitterAPIv2RequestParameter {`
`58`	`58`	`var commaSeparatedString: String {`
`59`	`59`	`return map { $0.stringValue }.sorted().joined(separator: ",")`
`60`	`60`	`}`