Skip to content

Commit 7399f95

Browse files
jo3binghamjo3bingham
committed
Better label TODOs/Unknowns
1 parent 4fe9177 commit 7399f95

32 files changed

Lines changed: 626 additions & 618 deletions

‎TibiaAPI/Network/ClientPackets/Attack.cs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ namespace OXGaming.TibiaAPI.Network.ClientPackets
55
public class Attack : ClientPacket
66
{
77
public uint CreatureId { get; set; }
8+
public uint SecondCreatureId { get; set; }
89

910
public Attack(Client client)
1011
{
@@ -15,14 +16,14 @@ public Attack(Client client)
1516
public override void ParseFromNetworkMessage(NetworkMessage message)
1617
{
1718
CreatureId = message.ReadUInt32();
18-
message.ReadUInt32(); // Creature ID again.
19+
SecondCreatureId = message.ReadUInt32(); // Should always be the same as CreatureId.
1920
}
2021

2122
public override void AppendToNetworkMessage(NetworkMessage message)
2223
{
2324
message.Write((byte)ClientPacketType.Attack);
2425
message.Write(CreatureId);
25-
message.Write(CreatureId);
26+
message.Write(SecondCreatureId);
2627
}
2728
}
2829
}

‎TibiaAPI/Network/ClientPackets/CyclopediaHouseAction.cs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ public class CyclopediaHouseAction : ClientPacket
66
{
77
public string Town { get; set; }
88

9-
public byte Unknown { get; set; }
10-
119
public CyclopediaHouseAction(Client client)
1210
{
1311
Client = client;
@@ -16,15 +14,17 @@ public CyclopediaHouseAction(Client client)
1614

1715
public override void ParseFromNetworkMessage(NetworkMessage message)
1816
{
19-
Unknown = message.ReadByte(); //always 0x00?
17+
// TODO
18+
message.ReadByte(); //always 0x00?
2019
Town = message.ReadString();
2120
}
2221

2322
public override void AppendToNetworkMessage(NetworkMessage message)
2423
{
25-
message.Write((byte)ClientPacketType.CyclopediaHouseAction);
26-
message.Write(Unknown);
27-
message.Write(Town);
24+
// TODO
25+
// message.Write((byte)ClientPacketType.CyclopediaHouseAction);
26+
// //message.Write(Unknown);
27+
// message.Write(Town);
2828
}
2929
}
3030
}

‎TibiaAPI/Network/ClientPackets/FeatureEvent.cs‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ namespace OXGaming.TibiaAPI.Network.ClientPackets
44
{
55
public class FeatureEvent : ClientPacket
66
{
7-
public uint Unknown { get; set; }
8-
97
public byte EventType { get; set; }
108

119
public bool ShowWindow { get; set; }
@@ -22,19 +20,21 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
2220
ShowWindow = message.ReadBool();
2321
if (!ShowWindow)
2422
{
25-
Unknown = message.ReadUInt32();
23+
// TODO
24+
message.ReadUInt32();
2625
}
2726
}
2827

2928
public override void AppendToNetworkMessage(NetworkMessage message)
3029
{
31-
message.Write((byte)ClientPacketType.FeatureEvent);
32-
message.Write(EventType);
33-
message.Write(ShowWindow);
34-
if (!ShowWindow)
35-
{
36-
message.Write(Unknown);
37-
}
30+
// TODO
31+
// message.Write((byte)ClientPacketType.FeatureEvent);
32+
// message.Write(EventType);
33+
// message.Write(ShowWindow);
34+
// if (!ShowWindow)
35+
// {
36+
// //message.Write(Unknown);
37+
// }
3838
}
3939
}
4040
}

‎TibiaAPI/Network/ClientPackets/Follow.cs‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ namespace OXGaming.TibiaAPI.Network.ClientPackets
55
public class Follow : ClientPacket
66
{
77
public uint CreatureId { get; set; }
8+
public uint SecondCreatureId { get; set; }
89

910
public Follow(Client client)
1011
{
@@ -15,14 +16,14 @@ public Follow(Client client)
1516
public override void ParseFromNetworkMessage(NetworkMessage message)
1617
{
1718
CreatureId = message.ReadUInt32();
18-
message.ReadUInt32(); // Creature ID again.
19+
SecondCreatureId = message.ReadUInt32(); // Should always be the same as CreatureId.
1920
}
2021

2122
public override void AppendToNetworkMessage(NetworkMessage message)
2223
{
2324
message.Write((byte)ClientPacketType.Follow);
2425
message.Write(CreatureId);
25-
message.Write(CreatureId);
26+
message.Write(SecondCreatureId);
2627
}
2728
}
2829
}

‎TibiaAPI/Network/ClientPackets/Greet.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
1717

1818
public override void AppendToNetworkMessage(NetworkMessage message)
1919
{
20-
message.Write((byte)ClientPacketType.Greet);
20+
// TODO
21+
// message.Write((byte)ClientPacketType.Greet);
2122
}
2223
}
2324
}

‎TibiaAPI/Network/ClientPackets/MonsterBonusEffectAction.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ public class MonsterBonusEffectAction : ClientPacket
66
{
77
public ushort RaceId { get; set; }
88

9-
public byte Type { get; set; }
109
public byte CharmId { get; set; }
10+
public byte Type { get; set; }
1111

1212
public MonsterBonusEffectAction(Client client)
1313
{

‎TibiaAPI/Network/ClientPackets/SetOutfit.cs‎

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ public class SetOutfit : ClientPacket
1212
public byte HeadColor { get; set; }
1313
public byte LegsColor { get; set; }
1414
public byte TorsoColor { get; set; }
15-
public byte Unknown { get; set; }
1615

1716
public SetOutfit(Client client)
1817
{
@@ -24,7 +23,8 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
2423
{
2524
if (Client.VersionNumber >= 12209066)
2625
{
27-
Unknown = message.ReadByte();
26+
// TODO
27+
message.ReadByte();
2828
}
2929
OutfitId = message.ReadUInt16();
3030
HeadColor = message.ReadByte();
@@ -37,17 +37,18 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
3737

3838
public override void AppendToNetworkMessage(NetworkMessage message)
3939
{
40-
message.Write((byte)ClientPacketType.SetOutfit);
41-
if (Client.VersionNumber >= 12209066)
42-
{
43-
message.Write(Unknown);
44-
}
45-
message.Write(OutfitId);
46-
message.Write(HeadColor);
47-
message.Write(TorsoColor);
48-
message.Write(LegsColor);
49-
message.Write(DetailColor);
50-
message.Write(MountId);
40+
// TODO
41+
// message.Write((byte)ClientPacketType.SetOutfit);
42+
// if (Client.VersionNumber >= 12209066)
43+
// {
44+
// // message.Write(Unknown);
45+
// }
46+
// message.Write(OutfitId);
47+
// message.Write(HeadColor);
48+
// message.Write(TorsoColor);
49+
// message.Write(LegsColor);
50+
// message.Write(DetailColor);
51+
// message.Write(MountId);
5152
}
5253
}
5354
}

‎TibiaAPI/Network/ClientPackets/StashAction.cs‎

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ public class StashAction : ClientPacket
1313
public ushort ItemId { get; set; }
1414

1515
public byte StashType { get; set; }
16-
public byte Unknown1 { get; set; }
17-
public byte Unknown2 { get; set; }
1816

1917
public StashAction(Client client)
2018
{
@@ -32,10 +30,10 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
3230
// Based on the following data: 01 FF FF 40 00 0A 3D 17 0A
3331
Position = message.ReadPosition();
3432
ItemId = message.ReadUInt16();
35-
Unknown1 = message.ReadByte();
33+
message.ReadByte();
3634
if (StashType == 0)
3735
{
38-
Unknown2 = message.ReadByte();
36+
message.ReadByte();
3937
}
4038
}
4139
else if (StashType == 3)
@@ -44,34 +42,35 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
4442
ItemCount = message.ReadUInt32();
4543
if (Client.VersionNumber >= 12200000)
4644
{
47-
Unknown1 = message.ReadByte();
45+
message.ReadByte();
4846
}
4947
}
5048
}
5149

5250
public override void AppendToNetworkMessage(NetworkMessage message)
5351
{
54-
message.Write((byte)ClientPacketType.StashAction);
55-
message.Write(StashType);
56-
if (StashType == 0 || StashType == 1 || StashType == 2)
57-
{
58-
message.Write(Position);
59-
message.Write(ItemId);
60-
message.Write(Unknown1);
61-
if (StashType == 0)
62-
{
63-
message.Write(Unknown2);
64-
}
65-
}
66-
else if (StashType == 3)
67-
{
68-
message.Write(ItemId);
69-
message.Write(ItemCount);
70-
if (Client.VersionNumber >= 12200000)
71-
{
72-
message.Write(Unknown1);
73-
}
74-
}
52+
// TODO
53+
// message.Write((byte)ClientPacketType.StashAction);
54+
// message.Write(StashType);
55+
// if (StashType == 0 || StashType == 1 || StashType == 2)
56+
// {
57+
// message.Write(Position);
58+
// message.Write(ItemId);
59+
// //message.Write(Unknown);
60+
// if (StashType == 0)
61+
// {
62+
// //message.Write(Unknown);
63+
// }
64+
// }
65+
// else if (StashType == 3)
66+
// {
67+
// message.Write(ItemId);
68+
// message.Write(ItemCount);
69+
// if (Client.VersionNumber >= 12200000)
70+
// {
71+
// //message.Write(Unknown);
72+
// }
73+
// }
7574
}
7675
}
7776
}

‎TibiaAPI/Network/ClientPackets/SubscribeToUpdates.cs‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ public override void ParseFromNetworkMessage(NetworkMessage message)
1717

1818
public override void AppendToNetworkMessage(NetworkMessage message)
1919
{
20-
message.Write((byte)ClientPacketType.SubscribeToUpdates);
20+
// TODO
21+
// message.Write((byte)ClientPacketType.SubscribeToUpdates);
2122
}
2223
}
2324
}

‎TibiaAPI/Network/ClientPackets/TournamentLeaderboard.cs‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,8 @@ namespace OXGaming.TibiaAPI.Network.ClientPackets
44
{
55
public class TournamentLeaderboard : ClientPacket
66
{
7-
private byte[] unknown;
8-
97
public string WorldName { get; set; }
108

11-
public byte Unknown { get; set; }
12-
139
public TournamentLeaderboard(Client client)
1410
{
1511
Client = client;
@@ -18,18 +14,15 @@ public TournamentLeaderboard(Client client)
1814

1915
public override void ParseFromNetworkMessage(NetworkMessage message)
2016
{
21-
Unknown = message.ReadByte();
17+
message.ReadByte(); // TODO
2218
WorldName = message.ReadString();
23-
unknown = message.ReadBytes(3);
24-
Client.Logger.Debug($"TournamentLeaderboard unknown data: {System.BitConverter.ToString(unknown).Replace('-', ' ')}");
19+
message.ReadBytes(3); // TODO
2520
}
2621

2722
public override void AppendToNetworkMessage(NetworkMessage message)
2823
{
29-
message.Write((byte)ClientPacketType.TournamentLeaderboard);
30-
message.Write(Unknown);
31-
message.Write(WorldName);
32-
message.Write(unknown);
24+
// TODO
25+
// message.Write((byte)ClientPacketType.TournamentLeaderboard);
3326
}
3427
}
3528
}

0 commit comments

Comments
 (0)