Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Tobimaru/Java_CardGame
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Tobimaru/Java_CardGame
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refactor-cards
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 7 files changed
  • 1 contributor

Commits on Apr 25, 2024

  1. upgrade compiler version to 21 in pom

    @Tobimaru
    Tobimaru committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bab9cf0 View commit details
    Browse the repository at this point in the history

  2. remove static method sortvalues in Rank and Suit 

    because it is not useful
    @Tobimaru
    Tobimaru committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e96c975 View commit details
    Browse the repository at this point in the history

  3. remove nmb_id field from Rank and Suit 

    because they should not define a value; it is responsibility of the card game
    @Tobimaru
    Tobimaru committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0eae83d View commit details
    Browse the repository at this point in the history

  4. use static initilization in BlackJack

    @Tobimaru
    Tobimaru committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0834bb7 View commit details
    Browse the repository at this point in the history

  5. refactor BJValue in BlackJack 

    to improve encapsulation, but apparently outer class maintain access
    @Tobimaru
    Tobimaru committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    0f45952 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2024

  1. instantiate generic HashMap properly

    @Tobimaru
    Tobimaru committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    b2bec27 View commit details
    Browse the repository at this point in the history
Loading