Modified the inline error() function to also throw a runtime_error#1192
Merged
KrisThielemans merged 3 commits intoUCL:masterfrom May 17, 2023
Conversation
Contributor
Author
|
@KrisThielemans : these two includes in common.h introduce circular dependencies if I want to include the TextWriter in error.h and warning.h : STIR/src/include/stir/common.h Line 296 in d23cda6 I guess this is why info.h (where the TextWriter is already used) is not included here, but instead wherever the info() function is used. I would propose to follow the same strategy for warning and error: remove them from common.h and instead include them where needed. Is that ok with you? |
added 2 commits
May 12, 2023 12:37
….h and was then able to replace cerr with writeText.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided against calling the other error function, because that one is deprecated.