prepare CListEventCylindricalScannerWithDiscreteDetectors for non-cylindrical#1222
Merged
KrisThielemans merged 1 commit intoUCL:masterfrom Jul 10, 2023
Merged
Conversation
Collaborator
Author
|
@danieldeidda @VietAnhDao I prefer this over #1209 and #994. I think it's cleaner and avoids type-casting all the time. (I guess it's less flexible as it relies on compilation-time decision on what the listmode data contains, but I think that makes sense in pretty much every case anyway) |
Collaborator
Author
|
@markus-jehl please check. It should not affect you at all, but will help later. |
…indrical - move all functionality to template class CListEventScannerWithDiscreteDetectors<ProjDataInfoT> - keep CListEventCylindricalScannerWithDiscreteDetectors as derived class such that this change is backwards compatible
3bfecf4 to
4bd016d
Compare
Contributor
|
Looks good to me! |
danieldeidda
approved these changes
Jul 10, 2023
Collaborator
danieldeidda
left a comment
There was a problem hiding this comment.
To be honest that's what I would have liked to do anyway. So looks good to me :D
This was referenced Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CListEventScannerWithDiscreteDetectors<ProjDataInfoT>CListEventCylindricalScannerWithDiscreteDetectorsas derived class such that this change is backwards compatible