Unaddressed review bot suggestions

PR #751 was merged with unaddressed review bot feedback.
Source PR: #751

Actionable comments

• coderabbitai[bot] (inc/checkout/class-cart.php): 🛠️ Refactor suggestion | 🟠 Major Use Yoda condition per coding guidelines. As per coding guidelines, production code should use Yoda conditions ('value' === $var): ```diff - if ($this->c...
• coderabbitai[bot] (inc/checkout/class-checkout.php): ⚠️ Potential issue | 🟡 Minor Fallback still depends on array pointer state. Line 1350 says “first entry” but uses current($sites), which can return a non-first element (or false) if the ...
• coderabbitai[bot] (inc/models/class-membership.php): ⚠️ Potential issue | 🟠 Major Unconditional clearing of date_cancellation in renew() affects all callers. Per the relevant code snippets, payment gateways (Stripe, PayPal) call renew() ...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🟠 Major Don't charge signup fees again on reactivation. Line 858 introduces a new cart type, but Line 2137 only exempts 'renewal' from signup fees. Because this branch...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🟠 Major Don't persist trial history during cart construction. Line 872 saves the customer before the reactivation is actually committed. Simply opening checkout, failing...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🟠 Major Disable the trial start date too. Line 2237 short-circuits has_trial(), but get_billing_start_date() is unchanged and done() still emits date_trial_end. ...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🟠 Major Reactivation path should not accept arbitrary request products. When products is provided, reactivation skips rebuilding from the original membership and retur...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🟠 Major Reactivation is not rebuilding the original membership faithfully. Lines 906-915 copy the membership duration after add_product() has already run, so the cart ...
• coderabbitai[bot] (inc/models/class-membership.php): ⚠️ Potential issue | 🔴 Critical
  🧩 Analysis chain

  🏁 Script executed: ```shell #!/bin/bash # Inspect renew() and reactivate() together with line numbers. nl -ba inc/m...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🔴 Critical
  🧩 Analysis chain

  🏁 Script executed: ```shell #!/bin/bash # Check if gateway handlers have been updated to handle reactivation cart t...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🟠 Major Potential null pointer dereference on $this->customer. Line 871 guards against a null customer with if ($this->customer && ...), but line 886 accesses `$this...
• coderabbitai[bot] (inc/checkout/class-cart.php): ⚠️ Potential issue | 🔴 Critical
  🧩 Analysis chain

  🏁 Script executed: ```shell #!/bin/bash # Verify the return structure of get_addon_products() rg -n -A 20 "public f...
• coderabbitai[bot] (inc/gateways/class-base-stripe-gateway.php): ⚠️ Potential issue | 🟠 Major trialing is lost in this recovery path. $new_status on Line 3252 is computed but never used. reactivate() always routes through renew(..., 'active', ...)...
• coderabbitai[bot] (inc/gateways/class-paypal-gateway.php): ⚠️ Potential issue | 🟠 Major Don’t redirect after a failed local transition. reactivate() / renew() can return false or WP_Error. Both checkout branches keep the PayPal payment/profi...
• coderabbitai[bot] (inc/gateways/class-paypal-rest-gateway.php): ⚠️ Potential issue | 🟠 Major Gate checkout success on a successful membership transition. Both branches ignore the return from reactivate() / renew(). If the membership save fails, the s...
• coderabbitai[bot] (inc/gateways/class-paypal-rest-gateway.php): ⚠️ Potential issue | 🟠 Major Use true in the subscription path. Line 1281 sets auto-renew on, but reactivate(false) / renew(false) immediately clear it again. That leaves a confirmed P...
• coderabbitai[bot] (inc/gateways/class-paypal-webhook-handler.php): ⚠️ Potential issue | 🟠 Major Check the transition result before acknowledging the webhook. reactivate() / renew() can fail. This branch still logs success and returns 200, so a failed lo...
• coderabbitai[bot]: Actionable comments posted: 4 > [!CAUTION] > Some comments are outside the diff and can’t be posted inline due to platform limitations. > > > >
  >

  ⚠️ Outside diff range comme...
• coderabbitai[bot]: Actionable comments posted: 3
  🤖 Prompt for all review comments with AI agents

  ``` Verify each finding against the current code and only fix it if needed. Inline com...
• coderabbitai[bot]: Actionable comments posted: 1
  🤖 Prompt for all review comments with AI agents

  ``` Verify each finding against the current code and only fix it if needed. Inline com...
• coderabbitai[bot]: Actionable comments posted: 3 > [!CAUTION] > Some comments are outside the diff and can’t be posted inline due to platform limitations. > > > >
  >

  ⚠️ Outside diff range comme...
• coderabbitai[bot]: Actionable comments posted: 3
  🤖 Prompt for all review comments with AI agents

  ``` Verify each finding against the current code and only fix it if needed. Inline com...
• coderabbitai[bot]: Actionable comments posted: 5
  🤖 Prompt for all review comments with AI agents

  ``` Verify each finding against the current code and only fix it if needed. Inline com...

aidevops.sh v3.8.1 with claude-sonnet-4-6 spent 1h 40m and 8 tokens on this as a headless worker.