(fix) split_bash_commands replaced; temp_dir fixture fix in some tests (OpenHands#3160)

tobitege · web-flow · commit 2533efabbb5f · 2024-07-29T17:05:58.000Z
* split_bash_commands replaced; temp_dir fixture fix in some tests

* tweak test_runtime

* skip 2 tests in test_runtime that need fixing in extra PR

* reverting bash parsing changes and re-enabled tests

* missed to revert a changed assert in test_runtime.py
diff --git a/tests/unit/test_event_stream.py b/tests/unit/test_event_stream.py
@@ -16,7 +16,7 @@
 def temp_dir(monkeypatch):
     # get a temporary directory
     with tempfile.TemporaryDirectory() as temp_dir:
-        pathlib.Path().mkdir(parents=True, exist_ok=True)
+        pathlib.Path(temp_dir).mkdir(parents=True, exist_ok=True)
         yield temp_dir
 
 
diff --git a/tests/unit/test_ipython.py b/tests/unit/test_ipython.py
@@ -14,7 +14,7 @@
 def temp_dir(monkeypatch):
     # get a temporary directory
     with tempfile.TemporaryDirectory() as temp_dir:
-        pathlib.Path().mkdir(parents=True, exist_ok=True)
+        pathlib.Path(temp_dir).mkdir(parents=True, exist_ok=True)
         yield temp_dir
 
 
diff --git a/tests/unit/test_runtime.py b/tests/unit/test_runtime.py
@@ -44,7 +44,7 @@ def print_method_name(request):
 def temp_dir(monkeypatch):
     # get a temporary directory
     with tempfile.TemporaryDirectory() as temp_dir:
-        pathlib.Path().mkdir(parents=True, exist_ok=True)
+        pathlib.Path(temp_dir).mkdir(parents=True, exist_ok=True)
         yield temp_dir
 
 
diff --git a/tests/unit/test_sandbox.py b/tests/unit/test_sandbox.py
@@ -32,11 +32,18 @@ def create_docker_box_from_app_config(
     )
 
 
+@pytest.fixture(autouse=True)
+def print_method_name(request):
+    print('\n########################################################################')
+    print(f'Running test: {request.node.name}')
+    print('########################################################################')
+
+
 @pytest.fixture
 def temp_dir(monkeypatch):
     # get a temporary directory
     with tempfile.TemporaryDirectory() as temp_dir:
-        pathlib.Path().mkdir(parents=True, exist_ok=True)
+        pathlib.Path(temp_dir).mkdir(parents=True, exist_ok=True)
         yield temp_dir
 
 
