Merge pull request #579 from Unpackerr/dn2_stdout_when_err

davidnewhall · web-flow · commit 150ac47c5069 · 2026-02-16T22:29:18.000-08:00
Logs fallback to stdout
diff --git a/pkg/unpackerr/logs.go b/pkg/unpackerr/logs.go
@@ -153,20 +153,30 @@ func (u *Unpackerr) setupLogging() {
 	}
 
 	if u.Config.LogFile != "" {
-		u.rotatorr = rotatorr.NewMust(rotate)
+		var err error
+
+		u.rotatorr, err = rotatorr.New(rotate)
+		if err != nil {
+			// Fall back to stdout so we don't hammer the filesystem with failed open attempts.
+			u.rotatorr = nil
+			_, _ = os.Stdout.WriteString("[Unpackerr] Log file unavailable (check path and permissions!!), " +
+				"logging to stdout only: " + err.Error() + "\n")
+		}
 	}
 
 	stderr := os.Stdout
 	if u.ErrorStdErr {
 		stderr = os.Stderr
 	}
 
+	useLogFile := u.Config.LogFile != "" && u.rotatorr != nil
+
 	switch { // only use MultiWriter if we have > 1 writer.
-	case !u.Config.Quiet && u.Config.LogFile != "":
+	case !u.Config.Quiet && useLogFile:
 		u.updateLogOutput(io.MultiWriter(u.rotatorr, os.Stdout), io.MultiWriter(u.rotatorr, stderr))
-	case !u.Config.Quiet && u.Config.LogFile == "":
+	case !u.Config.Quiet && !useLogFile:
 		u.updateLogOutput(os.Stdout, stderr)
-	case u.Config.LogFile == "":
+	case !useLogFile:
 		u.updateLogOutput(io.Discard, io.Discard) // default is "nothing"
 	default:
 		u.updateLogOutput(u.rotatorr, u.rotatorr)
