fix: disableExtensions

YousefED · web-flow · commit f53faa1d712d · 2024-11-20T17:52:24.000+01:00
diff --git a/packages/core/src/editor/BlockNoteEditor.ts b/packages/core/src/editor/BlockNoteEditor.ts
@@ -474,6 +474,12 @@ export class BlockNoteEditor<
           return ext;
         }
 
+        if (!ext.plugin) {
+          throw new Error(
+            "Extension should either be a TipTap extension or a ProseMirror plugin in a plugin property"
+          );
+        }
+
         // "blocknote" extensions (prosemirror plugins)
         return Extension.create({
           name: key,
diff --git a/packages/core/src/editor/BlockNoteExtensions.ts b/packages/core/src/editor/BlockNoteExtensions.ts
@@ -116,7 +116,7 @@ export const getBlockNoteExtensions = <
   ret["nodeSelectionKeyboard"] = new NodeSelectionKeyboardPlugin();
 
   const disableExtensions: string[] = opts.disableExtensions || [];
-  for (const ext of Object.keys(disableExtensions)) {
+  for (const ext of disableExtensions) {
     delete ret[ext];
   }
 

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ export const getBlockNoteExtensions = <`
`116`	`116`	`ret["nodeSelectionKeyboard"] = new NodeSelectionKeyboardPlugin();`
`117`	`117`
`118`	`118`	`const disableExtensions: string[] = opts.disableExtensions \|\| [];`
`119`		`- for (const ext of Object.keys(disableExtensions)) {`
	`119`	`+ for (const ext of disableExtensions) {`
`120`	`120`	`delete ret[ext];`
`121`	`121`	`}`
`122`	`122`