Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tngan/samlify
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Zaptic/samlify
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Jul 9, 2018

  1. Fix missing dependency error 

    Like travis has here https://travis-ci.org/tngan/samlify/jobs/401602020
I have encountered an error arround the xml-encryption library. For some
reason it seems to have been missing. Adding the prefix `@passify/'
seems to fix it.

This is not related to the current PR and you might want extract this
commit if the rest of the PR fails for some reason.
    Ben committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    9c8aa64 View commit details
    Browse the repository at this point in the history

  2. Return InResponseTo field from parseLoginResponse 

    This seems to be returning the right field and should allow the users to
check that the id matches the nonce that was send during sp initiated
logins.

I've updated the exsiting tests rather than creating a new one because
this is not really a new use case.
    Ben committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    93e6dde View commit details
    Browse the repository at this point in the history
Loading