fix(plugins): small fix for differing dist tags of plugins

imhoffd · imhoffd · commit 3adfcb631417 · 2017-07-27T13:06:55.000-05:00
diff --git a/packages/cli-utils/src/lib/plugins.ts b/packages/cli-utils/src/lib/plugins.ts
@@ -367,8 +367,7 @@ async function facilitateIonicUpdate(env: IonicEnvironment, ionicPlugin: Hydrate
 }
 
 async function facilitatePluginUpdate(env: IonicEnvironment, ionicPlugin: HydratedPlugin, plugin: HydratedPlugin): Promise<boolean> {
-  const ionicPluginInstallPath = path.dirname(path.dirname(path.dirname(ionicPlugin.meta.filePath)));
-  const global = (!env.meta || !env.meta.local) && !plugin.meta.filePath.startsWith(ionicPluginInstallPath);
+  const global = !env.meta || !env.meta.local;
   const pluginInstallArgs = await pkgInstallPluginArgs(env, plugin.name, { global });
   const startMsg = `${global ? 'Global' : 'Local'} plugin ${chalk.green(plugin.name)}`;
   const updateMsg = `${startMsg} has an update available (${chalk.green(plugin.currentVersion)} => ${chalk.green(plugin.latestVersion)})!`;

Original file line number	Diff line number	Diff line change
`@@ -367,8 +367,7 @@ async function facilitateIonicUpdate(env: IonicEnvironment, ionicPlugin: Hydrate`
`367`	`367`	`}`
`368`	`368`
`369`	`369`	`async function facilitatePluginUpdate(env: IonicEnvironment, ionicPlugin: HydratedPlugin, plugin: HydratedPlugin): Promise<boolean> {`
`370`		`- const ionicPluginInstallPath = path.dirname(path.dirname(path.dirname(ionicPlugin.meta.filePath)));`
`371`		`- const global = (!env.meta \|\| !env.meta.local) && !plugin.meta.filePath.startsWith(ionicPluginInstallPath);`
	`370`	`+ const global = !env.meta \|\| !env.meta.local;`
`372`	`371`	`const pluginInstallArgs = await pkgInstallPluginArgs(env, plugin.name, { global });`
`373`	`372`	const startMsg = `${global ? 'Global' : 'Local'} plugin ${chalk.green(plugin.name)}`;
`374`	`373`	const updateMsg = `${startMsg} has an update available (${chalk.green(plugin.currentVersion)} => ${chalk.green(plugin.latestVersion)})!`;