refactor(daemon): restart if no process by pid file found

imhoffd · imhoffd · commit 5ceed035b8fd · 2017-07-25T16:44:02.000-05:00
diff --git a/packages/cli-utils/src/lib/daemon.ts b/packages/cli-utils/src/lib/daemon.ts
@@ -84,6 +84,20 @@ export class Daemon extends BaseConfig<DaemonFile> {
   }
 }
 
+export function processRunning(pid: number): boolean {
+  try {
+    const r = process.kill(pid, 0);
+
+    if (typeof r === 'boolean') {
+      return r;
+    }
+
+    return true;
+  } catch (e) {
+    return e.code === 'EPERM';
+  }
+}
+
 export async function checkForDaemon(env: IonicEnvironment): Promise<number> {
   const config = await env.config.load();
 
@@ -93,9 +107,8 @@ export async function checkForDaemon(env: IonicEnvironment): Promise<number> {
 
   const f = await env.daemon.getPid();
 
-  env.log.debug(() => `Daemon pid file found (${chalk.bold(String(f))})`);
-
-  if (f) {
+  if (f && processRunning(f)) {
+    env.log.debug(() => `Daemon found (pid: ${chalk.bold(String(f))})`);
     return f;
   }
 
diff --git a/packages/ionic/src/commands/daemon.ts b/packages/ionic/src/commands/daemon.ts
@@ -9,6 +9,7 @@ import {
   fsUnlink,
   pkgLatestVersion,
   prettyPath,
+  processRunning,
 } from '@ionic/cli-utils';
 
 @CommandMetadata({
@@ -51,6 +52,9 @@ export class DaemonCommand extends Command {
         this.env.log.info(`Killing existing daemon process ${chalk.bold(String(f))}.`);
         await fsUnlink(this.env.daemon.pidFilePath);
         process.kill(Number(f));
+      } else if (!processRunning(f)) {
+        this.env.log.info(`Process ${chalk.bold(String(f))} not found, deleting pid file.`);
+        await fsUnlink(this.env.daemon.pidFilePath);
       } else if (d.latestVersions.latest.ionic && semver.gt(this.env.plugins.ionic.version, d.latestVersions.latest.ionic)) {
         this.env.log.info(`Daemon out-of-date--killing ${chalk.bold(String(f))}.`);
         await fsUnlink(this.env.daemon.pidFilePath);
