fix: hash changed to external in crank-todomvc

fritx · fritx · commit a0f7361b954d · 2020-04-23T09:39:26.000+08:00
diff --git a/public/code/crank-async-generator.jsx b/public/code/crank-async-generator.jsx
@@ -8,7 +8,7 @@ const {createElement, renderer} = Crank;
 
 appendCss(`
 #mountNode { padding: 20px }
-`)
+`);
 
 // https://github.com/bikeshaving/crank/tree/master/examples/async-generator
 const mount = document.getElementById("mountNode");
@@ -21,7 +21,7 @@ async function* List(
   for await ({elems} of this) {
     i++;
     if (i % 5 === 0) {
-      yield <div>Loading {elems.length} items...</div>;
+      yield (<div>Loading {elems.length} items...</div>);
       await new Promise((resolve) => setTimeout(resolve, 4000));
     }
     yield (
diff --git a/public/code/crank-todomvc.jsx b/public/code/crank-todomvc.jsx
@@ -253,7 +253,12 @@ function save(todos) {
 }
 
 function* App() {
-  let todos = [];
+  // let todos = [];
+  let todos = [
+    { id: 1, title: 'sports', completed: true },
+    { id: 2, title: 'learn crank', completed: false },
+    { id: 3, title: 'get to work', completed: false },
+  ];
   let nextTodoId = 0;
   try {
     const storedTodos = JSON.parse(localStorage.getItem(STORAGE_KEY));
@@ -321,8 +326,10 @@ function* App() {
         break;
       }
       default: {
-        filter = "";
-        window.location.hash = `${prefix}/`;
+        if (window.location.hash.startsWith(`${prefix}/`)) {
+          filter = "";
+          window.location.hash = `${prefix}/`;
+        }
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -253,7 +253,12 @@ function save(todos) {`
`253`	`253`	`}`
`254`	`254`
`255`	`255`	`function* App() {`
`256`		`- let todos = [];`
	`256`	`+ // let todos = [];`
	`257`	`+ let todos = [`
	`258`	`+ { id: 1, title: 'sports', completed: true },`
	`259`	`+ { id: 2, title: 'learn crank', completed: false },`
	`260`	`+ { id: 3, title: 'get to work', completed: false },`
	`261`	`+ ];`
`257`	`262`	`let nextTodoId = 0;`
`258`	`263`	`try {`
`259`	`264`	`const storedTodos = JSON.parse(localStorage.getItem(STORAGE_KEY));`
`@@ -321,8 +326,10 @@ function* App() {`
`321`	`326`	`break;`
`322`	`327`	`}`
`323`	`328`	`default: {`
`324`		`- filter = "";`
`325`		- window.location.hash = `${prefix}/`;
	`329`	+ if (window.location.hash.startsWith(`${prefix}/`)) {
	`330`	`+ filter = "";`
	`331`	+ window.location.hash = `${prefix}/`;
	`332`	`+ }`
`326`	`333`	`}`
`327`	`334`	`}`
`328`	`335`