Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lapsio/JavaScript-ID3-Reader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: aadsm/JavaScript-ID3-Reader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 16 files changed
  • 8 contributors

Commits on Mar 17, 2014

  1. Configuration menu
    Copy the full SHA
    ef9824b View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2014

  1. Update minimized version

    aadsm committed Mar 18, 2014
    Configuration menu
    Copy the full SHA
    8c5a133 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2014

  1. Add options.onError to handle errors

    This was a two fold problem:
     - The data reader was not passing enough information to the fncError callback function it received. It was not using the fncError when making HEAD requests.
     - ID3 was never using the fncError callback error function provided by the dataReader.
    aadsm committed Apr 6, 2014
    Configuration menu
    Copy the full SHA
    c3fb4b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    251daaf View commit details
    Browse the repository at this point in the history
  3. Change compiler.jar path to be local

    I guess most people will just put it in the same folder.
    aadsm committed Apr 6, 2014
    Configuration menu
    Copy the full SHA
    073af6f View commit details
    Browse the repository at this point in the history
  4. Merge branch 'gh-28_error-handling'

    Conflicts:
    	dist/id3-minimized.js
    aadsm committed Apr 6, 2014
    Configuration menu
    Copy the full SHA
    4978f96 View commit details
    Browse the repository at this point in the history
  5. Check for 206 status on HEAD requests

    It seems that Firefox 28 is returning status code 206 when the file has
    been cached. This is odd because 206 stands for Partial Content
    which only makes sense for GET Range requests...
    aadsm committed Apr 6, 2014
    Configuration menu
    Copy the full SHA
    60dd82f View commit details
    Browse the repository at this point in the history
  6. Merge pull request aadsm#34 from aadsm/gh-33_head-206-status

    Check for 206 status on HEAD requests
    aadsm committed Apr 6, 2014
    Configuration menu
    Copy the full SHA
    d9b62c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2014

  1. Removed document.write call and replaced with an appendChild call.

    Replaced document.write call that adds VBScript with a document.appendChild call due to the document.write call failing when script is loaded asynchronously
    maniacalmaniac authored and aadsm committed Apr 27, 2014
    Configuration menu
    Copy the full SHA
    4ed3614 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2015

  1. Configuration menu
    Copy the full SHA
    b200b94 View commit details
    Browse the repository at this point in the history
  2. Fix header type

    aadsm committed Jan 12, 2015
    Configuration menu
    Copy the full SHA
    725dfb5 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2015

  1. Update bufferedbinaryajax.js

    tests will throw an error on iphone:TypeError: Cannot read property 'data' of undefined
    janryWang committed Jan 27, 2015
    Configuration menu
    Copy the full SHA
    506e9ed View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2015

  1. Fixed 'If-Modified-Since' date format

    Hi,
    
    My IIS 8.5 server was causing me trouble with the If-Modified-Since header, and returning a 400 code. After investigating it seems that the date should be in RFC822 or RFC1123 format, and both of which require that the day be formatted with a leading 0.
    
    Anyway, adding the 0 fixed my problem.
    
    Hope that helps someone else.
    
    Cheers
    Xavier
    xps committed Feb 10, 2015
    Configuration menu
    Copy the full SHA
    2790d1f View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2015

  1. Merge pull request aadsm#47 from xps/patch-1

    Fixed 'If-Modified-Since' date format
    aadsm committed Feb 23, 2015
    Configuration menu
    Copy the full SHA
    32733e0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request aadsm#46 from janryWang/master

    Update bufferedbinaryajax.js
    aadsm committed Feb 23, 2015
    Configuration menu
    Copy the full SHA
    fe76e1f View commit details
    Browse the repository at this point in the history

Commits on May 8, 2015

  1. Update README.md

    Add Cordova / PhotoGap usage
    aadsm committed May 8, 2015
    Configuration menu
    Copy the full SHA
    6ea55cd View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2015

  1. Node.js & Browserify compatibility

    - add package.json with build deps and server-side deps
    - move to commonjs dependencies, don't expose globals
    - change FileAPIReader to be a property of ID3 instead of global (breaking)
    - use browserify with --standalone (for UMD compatibility)
    - update README with node.js & UMD usage instructions
    - bump major version since we're introducing a breaking change (FileAPIReader access)
    jesseditson authored and aadsm committed Nov 9, 2015
    Configuration menu
    Copy the full SHA
    da09b42 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2016

  1. Update README.md

    Add note about jsmediatags
    aadsm committed Jan 17, 2016
    Configuration menu
    Copy the full SHA
    e5e2834 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2016

  1. Add missing try/catch block

    vyorkin committed Sep 5, 2016
    Configuration menu
    Copy the full SHA
    42bb7fb View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2016

  1. Merge pull request aadsm#60 from vyorkin-forks/master

    Add missing try/catch block
    aadsm authored Sep 6, 2016
    Configuration menu
    Copy the full SHA
    3ef70f3 View commit details
    Browse the repository at this point in the history
Loading