Make P4 temp workspace persistent for graph execution

sebastianrath · sebastianrath · commit c8e03f292b9b · 2026-04-08T23:31:21.000-04:00
The worker must run in the workspace root so p4 sync in graph nodes
can resolve paths correctly. Without Persistent: true, the worker
copies the script to a separate work/ dir and deletes the checkout.
diff --git a/agent/vcs/p4.go b/agent/vcs/p4.go
@@ -132,7 +132,7 @@ func (p *P4Provider) Checkout(ctx context.Context, url, ref, pipeline, destDir s
 		return CheckoutResult{}, fmt.Errorf("p4 sync pipeline file failed: %w", err)
 	}
 
-	return CheckoutResult{Dir: absDir, P4Client: p.clientName}, nil
+	return CheckoutResult{Dir: absDir, Persistent: true, P4Client: p.clientName}, nil
 }
 
 func (p *P4Provider) Cleanup(ctx context.Context) error {

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ func (p *P4Provider) Checkout(ctx context.Context, url, ref, pipeline, destDir s`
`132`	`132`	`return CheckoutResult{}, fmt.Errorf("p4 sync pipeline file failed: %w", err)`
`133`	`133`	`}`
`134`	`134`
`135`		`- return CheckoutResult{Dir: absDir, P4Client: p.clientName}, nil`
	`135`	`+ return CheckoutResult{Dir: absDir, Persistent: true, P4Client: p.clientName}, nil`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`func (p *P4Provider) Cleanup(ctx context.Context) error {`