always sanitize final glyph names

frankrolf · frankrolf · commit 406ca5fcdaa4 · 2025-03-04T15:12:17.000+01:00
diff --git a/goadbWriter.py b/goadbWriter.py
@@ -371,7 +371,8 @@ def __init__(self, gn_friendly, g=None, gn_final=None, cp_override=None):
         # this is the normal expectation for most glyphs
         if self.gn_final is None:
             self.assign_final_and_cp_override()
-            self.gn_final = sanitize_final_gname(self.gn_final)
+
+        self.gn_final = sanitize_final_gname(self.gn_final)
 
         # in other cases (alternates/ligatures), we generate the final name
         # outside, and use this object for data storage only.
diff --git a/tests/test_goadbWriter.py b/tests/test_goadbWriter.py
@@ -6,7 +6,7 @@
 
 
 sys.path.append("..")
-from goadbWriter import _get_args, main
+from goadbWriter import _get_args, main, GlyphBaptism
 
 
 TEST_DIR = Path(__file__).parent
@@ -38,6 +38,15 @@ def test_get_args():
     assert argparse_args == expected_args
 
 
+def test_gname_sanitizing():
+    '''
+    make sure input glyph names are properly sanitized
+    '''
+    gname_dirty = 'A.#E81416FF'
+    gb = GlyphBaptism(gname_dirty)
+    assert '#' not in gb.gn_final
+
+
 def test_phantom_input_ufo(capsys):
     '''
     non-existent input UFO
