Skip to content

Commit f23eb84

Browse files
leahecoleengelkenicain
authored
fix flaky test: add httperror to backoff check (GoogleCloudPlatform#9161)
* add httperror to backoff check * fix import order --------- Co-authored-by: Charles Engelke <[email protected]> Co-authored-by: nicain <[email protected]>
1 parent 7c183c0 commit f23eb84

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

jobs/v3/api_client/commute_search_sample_test.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import re
1616

1717
import backoff
18+
from googleapiclient.errors import HttpError
1819
import pytest
1920

2021
import commute_search_sample
@@ -28,7 +29,7 @@ def company_name():
2829

2930

3031
def test_commute_search_sample(company_name, capsys):
31-
@backoff.on_exception(backoff.expo, AssertionError, max_time=240)
32+
@backoff.on_exception(backoff.expo, (AssertionError, HttpError), max_time=240)
3233
def eventually_consistent_test():
3334
commute_search_sample.run_sample(company_name)
3435
out, _ = capsys.readouterr()

0 commit comments

Comments
 (0)