Unnecessary list literal → set literal (zarr-developers#1534)

DimitriPapadopoulos · web-flow · commit 16c2684345a6 · 2023-10-27T00:12:46.000+02:00
* Unnecessary list literal → set literal

Why use a list literal to initialise a set? Just use a set literal.

* Add release note for previous commit

Signed-off-by: Dimitri Papadopoulos &lt;3234522+DimitriPapadopoulos@users.noreply.github.com&gt;

---------

Signed-off-by: Dimitri Papadopoulos &lt;3234522+DimitriPapadopoulos@users.noreply.github.com&gt;
diff --git a/docs/release.rst b/docs/release.rst
@@ -21,6 +21,9 @@ Unreleased
 Maintenance
 ~~~~~~~~~~~
 
+* Initialise some sets in tests with set literals instead of list literals.
+  By :user:`Dimitri Papadopoulos Orfanos <DimitriPapadopoulos>` :issue:`1534`.
+
 * Allow ``black`` code formatter to be run with any Python version.
   By :user:`David Stansby <dstansby>` :issue:`1549`
 
diff --git a/zarr/tests/test_storage.py b/zarr/tests/test_storage.py
@@ -1166,9 +1166,9 @@ def test_deep_ndim(self):
         if self.version == 2:
             assert set(store.listdir()) == {".zgroup", "bar"}
         else:
-            assert set(store.listdir()) == set(["data", "meta", "zarr.json"])
-            assert set(store.listdir("meta/root/" + path)) == set(["bar", "bar.group.json"])
-            assert set(store.listdir("data/root/" + path)) == set(["bar"])
+            assert set(store.listdir()) == {"data", "meta", "zarr.json"}
+            assert set(store.listdir("meta/root/" + path)) == {"bar", "bar.group.json"}
+            assert set(store.listdir("data/root/" + path)) == {"bar"}
         assert foo["bar"]["baz"][(0, 0, 0)] == 1
 
     def test_not_fsspec(self):
