chore(ci): add codecov upload to tests GHA run & update dev guide#433
chore(ci): add codecov upload to tests GHA run & update dev guide#433lwasser merged 5 commits intoall-contributors:mainfrom
Conversation
|
Uploads are working! you can see that codecove is watching this pr but we will have to merge to main to update things formally. i just fixed lint locally and now it's broken again so let me figure out why. |
chore: add docs for codecov and secret to workflow chore: double check cov file exists? yay Apply suggestion from @lwasser sdf
JimMadge
left a comment
There was a problem hiding this comment.
Good stuff 🎉. A few comments.
I really like that we are documenting this sort of thing. We can move to the docs eventually, but capturing it somewhere is most important.
| - **Branches:** 50% | ||
| - **Functions:** 40% | ||
| - **Lines:** 50% | ||
| - **Statements:** 50% |
There was a problem hiding this comment.
Maybe this should be a table? Not a big deal either way.
Co-authored-by: Jim Madge <[email protected]>
Co-authored-by: Jim Madge <[email protected]>
| @@ -30,13 +30,14 @@ jobs: | |||
| run: pnpm build | |||
There was a problem hiding this comment.
@JimMadge i'm using pnpm here.
let's open an issue because again i don't have specific preferences here I was just following another more recent pr that we had. and migrated over to pnpm. i'll open an issue now, merge this and then when we decide we can update consistently everywhere!
Thanks for the review! I figure since we're learning as we go it makes sense to document. and then in the end we can definitely pull it over to the docs. I just think every pr updates something that we have to document right now so it's easier to do it here first. 😆 so much to do!! |
closes #432
What:
This pr adds codecov upload so we can view reports and see changes. this is mostly for unit type testing but it's helpful to have a visual of coverage
Why:
How:
Checklist: